[PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups

Ilpo Järvinen posted 8 patches 9 months, 1 week ago
drivers/infiniband/hw/hfi1/pcie.c           |  9 ++-------
drivers/media/pci/cobalt/cobalt-driver.c    | 11 ++++++-----
drivers/net/ethernet/intel/e1000e/defines.h |  3 ---
drivers/net/ethernet/intel/e1000e/mac.c     | 18 ++++++++----------
drivers/net/ethernet/intel/igb/e1000_mac.c  |  6 +++---
drivers/pci/controller/dwc/pcie-tegra194.c  |  9 ++++-----
drivers/pci/controller/pci-mvebu.c          |  2 +-
drivers/pci/pci-sysfs.c                     |  5 ++---
drivers/pci/pci.c                           |  6 +++---
9 files changed, 29 insertions(+), 40 deletions(-)
[PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups
Posted by Ilpo Järvinen 9 months, 1 week ago
Instead of custom code to extract the PCIe capabilities, make the code
more obvious using FIELD_GET/PREP().

Also cleanup some duplicated defines in e1000e.

This is just a step into the right direction, there's plenty of places
still to cleanup which will have to wait for another patch series.

v3:
- Remove applied patches (scsi)
- Use pci_pcie_cap() and tweak local variable (e1000e)
- Use the correct prefix for RDMA/hfi1

v2:
- Remove extract_width() and use FIELD_GET() directly (IB/hfi1)
- Convert other fields beside Link Width ones
- Remove useless u8 casts (scsi: esas2r)
- e1000e:
        - Remove defines that duplicate pci_regs.h ones
        - Convert to pcie_capability_read_word()


Ilpo Järvinen (8):
  RDMA/hfi1: Use FIELD_GET() to extract Link Width
  media: cobalt: Use FIELD_GET() to extract Link Width
  igb: Use FIELD_GET() to extract Link Width
  PCI: tegra194: Use FIELD_GET()/FIELD_PREP() with Link Width fields
  PCI: mvebu: Use FIELD_PREP() with Link Width
  PCI: Use FIELD_GET() to extract Link Width
  e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom
    defines/code
  e1000e: Use pcie_capability_read_word() for reading LNKSTA

 drivers/infiniband/hw/hfi1/pcie.c           |  9 ++-------
 drivers/media/pci/cobalt/cobalt-driver.c    | 11 ++++++-----
 drivers/net/ethernet/intel/e1000e/defines.h |  3 ---
 drivers/net/ethernet/intel/e1000e/mac.c     | 18 ++++++++----------
 drivers/net/ethernet/intel/igb/e1000_mac.c  |  6 +++---
 drivers/pci/controller/dwc/pcie-tegra194.c  |  9 ++++-----
 drivers/pci/controller/pci-mvebu.c          |  2 +-
 drivers/pci/pci-sysfs.c                     |  5 ++---
 drivers/pci/pci.c                           |  6 +++---
 9 files changed, 29 insertions(+), 40 deletions(-)

-- 
2.30.2

Re: [PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups
Posted by Bjorn Helgaas 8 months, 2 weeks ago
On Tue, Sep 19, 2023 at 03:56:40PM +0300, Ilpo Järvinen wrote:
> Instead of custom code to extract the PCIe capabilities, make the code
> more obvious using FIELD_GET/PREP().
> 
> Also cleanup some duplicated defines in e1000e.
> 
> This is just a step into the right direction, there's plenty of places
> still to cleanup which will have to wait for another patch series.
> 
> v3:
> - Remove applied patches (scsi)
> - Use pci_pcie_cap() and tweak local variable (e1000e)
> - Use the correct prefix for RDMA/hfi1
> 
> v2:
> - Remove extract_width() and use FIELD_GET() directly (IB/hfi1)
> - Convert other fields beside Link Width ones
> - Remove useless u8 casts (scsi: esas2r)
> - e1000e:
>         - Remove defines that duplicate pci_regs.h ones
>         - Convert to pcie_capability_read_word()
> 
> 
> Ilpo Järvinen (8):
>   RDMA/hfi1: Use FIELD_GET() to extract Link Width
>   media: cobalt: Use FIELD_GET() to extract Link Width
>   igb: Use FIELD_GET() to extract Link Width

>   PCI: tegra194: Use FIELD_GET()/FIELD_PREP() with Link Width fields
>   PCI: mvebu: Use FIELD_PREP() with Link Width
>   PCI: Use FIELD_GET() to extract Link Width

Applied these three drivers/pci patches to pci/field-get for v6.7,
thanks!

>   e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom
>     defines/code
>   e1000e: Use pcie_capability_read_word() for reading LNKSTA
> 
>  drivers/infiniband/hw/hfi1/pcie.c           |  9 ++-------
>  drivers/media/pci/cobalt/cobalt-driver.c    | 11 ++++++-----
>  drivers/net/ethernet/intel/e1000e/defines.h |  3 ---
>  drivers/net/ethernet/intel/e1000e/mac.c     | 18 ++++++++----------
>  drivers/net/ethernet/intel/igb/e1000_mac.c  |  6 +++---
>  drivers/pci/controller/dwc/pcie-tegra194.c  |  9 ++++-----
>  drivers/pci/controller/pci-mvebu.c          |  2 +-
>  drivers/pci/pci-sysfs.c                     |  5 ++---
>  drivers/pci/pci.c                           |  6 +++---
>  9 files changed, 29 insertions(+), 40 deletions(-)
> 
> -- 
> 2.30.2
> 
Re: [PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups
Posted by Leon Romanovsky 9 months, 1 week ago
On Tue, Sep 19, 2023 at 03:56:40PM +0300, Ilpo Järvinen wrote:
> Instead of custom code to extract the PCIe capabilities, make the code
> more obvious using FIELD_GET/PREP().
> 
> Also cleanup some duplicated defines in e1000e.
> 
> This is just a step into the right direction, there's plenty of places
> still to cleanup which will have to wait for another patch series.
> 
> v3:
> - Remove applied patches (scsi)
> - Use pci_pcie_cap() and tweak local variable (e1000e)
> - Use the correct prefix for RDMA/hfi1
> 
> v2:
> - Remove extract_width() and use FIELD_GET() directly (IB/hfi1)
> - Convert other fields beside Link Width ones
> - Remove useless u8 casts (scsi: esas2r)
> - e1000e:
>         - Remove defines that duplicate pci_regs.h ones
>         - Convert to pcie_capability_read_word()
> 
> 
> Ilpo Järvinen (8):
>   RDMA/hfi1: Use FIELD_GET() to extract Link Width

Applied this patch to RDMA tree.

Thanks
Re: (subset) [PATCH v3 0/8] PCI/treewide: PCIe capability access cleanups
Posted by Leon Romanovsky 9 months, 1 week ago
On Tue, 19 Sep 2023 15:56:40 +0300, Ilpo Järvinen wrote:
> Instead of custom code to extract the PCIe capabilities, make the code
> more obvious using FIELD_GET/PREP().
> 
> Also cleanup some duplicated defines in e1000e.
> 
> This is just a step into the right direction, there's plenty of places
> still to cleanup which will have to wait for another patch series.
> 
> [...]

Applied, thanks!

[1/8] RDMA/hfi1: Use FIELD_GET() to extract Link Width
      https://git.kernel.org/rdma/rdma/c/8bf7187d978610

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>