[v1] net: sched: htb: dont intepret cls results when asked to drop

[PATCH] net: sched: htb: dont intepret cls results when asked to drop

Ma Ke posted 1 patch 2 years, 4 months ago

Diff against v1
Download mbox

There is a newer version of this series

net/sched/sch_htb.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] net: sched: htb: dont intepret cls results when asked to drop

Posted by Ma Ke 2 years, 4 months ago

If asked to drop a packet via TC_ACT_SHOT it is unsafe to
assume that res.class contains a valid pointer.

Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
 net/sched/sch_htb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/sched/sch_htb.c b/net/sched/sch_htb.c
index 0d947414e616..5e8bd23d972f 100644
--- a/net/sched/sch_htb.c
+++ b/net/sched/sch_htb.c
@@ -243,6 +243,8 @@ static struct htb_class *htb_classify(struct sk_buff *skb, struct Qdisc *sch,
 
 	*qerr = NET_XMIT_SUCCESS | __NET_XMIT_BYPASS;
 	while (tcf && (result = tcf_classify(skb, NULL, tcf, &res, false)) >= 0) {
+		if (result == TC_ACT_SHOT)
+			return NULL;
 #ifdef CONFIG_NET_CLS_ACT
 		switch (result) {
 		case TC_ACT_QUEUED:
-- 
2.37.2