[v2] ASoC: dwc: fix typo in comment

[PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Myunguk Kim 2 years, 3 months ago

ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
according to the datasheet.

So, the comment should be RX, not TX

Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
---
 sound/soc/dwc/dwc-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 22c004179214..c71c17ef961d 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
 			irq_valid = true;
 		}
 
-		/* Error Handling: TX */
+		/* Error Handling: RX */
 		if (isr[i] & ISR_RXFO) 
{ 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
 			irq_valid = true;
-- 
2.34.1

Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Mark Brown 2 years, 3 months ago

On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
> 
> So, the comment should be RX, not TX

This patch still doesn't apply:

>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);

The patch is obviously corrupted, the { there should be on the prior
line and even fixing that by hand there appear to be some other issues.

Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Myunguk Kim 2 years, 3 months ago

> The patch is obviously corrupted, the { there should be on the prior
> line and even fixing that by hand there appear to be some other issues.

The patch file should have been attached as shown below. 
Is there a problem with my git send-email?

---
 sound/soc/dwc/dwc-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 22c004179214..c71c17ef961d 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
 			irq_valid = true;
 		}
 
-		/* Error Handling: TX */
+		/* Error Handling: RX */
 		if (isr[i] & ISR_RXFO) 
{ 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
 			irq_valid = true;
-- 

Thanks,
myunguk

Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Uwe Kleine-König 2 years, 3 months ago

On Thu, Sep 14, 2023 at 09:56:34AM +0900, Myunguk Kim wrote:
> > The patch is obviously corrupted, the { there should be on the prior
> > line and even fixing that by hand there appear to be some other issues.
> 
> The patch file should have been attached as shown below. 
> Is there a problem with my git send-email?
> 
> ---
>  sound/soc/dwc/dwc-i2s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
>  			irq_valid = true;
>  		}
>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
>  			irq_valid = true;

FTR: I get this mail directly (so no mailing list server involved), and
the patch is mangled in the same way as broonie pointed out in his mail
earlier in this thread.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Mark Brown 2 years, 3 months ago

On Thu, Sep 14, 2023 at 08:32:48AM +0200, Uwe Kleine-König wrote:
> On Thu, Sep 14, 2023 at 09:56:34AM +0900, Myunguk Kim wrote:
> > > The patch is obviously corrupted, the { there should be on the prior
> > > line and even fixing that by hand there appear to be some other issues.

> > The patch file should have been attached as shown below. 
> > Is there a problem with my git send-email?

> > +		/* Error Handling: RX */
> >  		if (isr[i] & ISR_RXFO) 
> > { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);

> FTR: I get this mail directly (so no mailing list server involved), and
> the patch is mangled in the same way as broonie pointed out in his mail
> earlier in this thread.

Right, same here.  I don't know where the problem might be, it's not a
pattern I've seen before.

Re: [PATCH] [v2] ASoC: dwc: fix typo in comment

Posted by Bagas Sanjaya 2 years, 3 months ago

On Wed, Sep 13, 2023 at 11:41:04AM +0900, Myunguk Kim wrote:
> ISR_RXFO means "Status of Data Overrun interrupt for the RX channel"
> according to the datasheet.
> 
> So, the comment should be RX, not TX

Thanks for better description!

The patch title though, I'd like to write it as "ASoC: dwc: correct ISR_RXFO
check comment".

> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
> ---
>  sound/soc/dwc/dwc-i2s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 22c004179214..c71c17ef961d 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
>  			irq_valid = true;
>  		}
>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
>  			irq_valid = true;

In any case,

Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara