[v2] riscv: dts: thead: set dma-noncoherent to soc bus

[PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Jisheng Zhang 2 years, 3 months ago

riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
dma coherent, so set dma-noncoherent to reflect this fact.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Tested-by: Drew Fustini <dfustini@baylibre.com>
---

Since v1:
 - rebase on v6.6-rc1
 - collect Tested-by tag

 arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
index ce708183b6f6..ff364709a6df 100644
--- a/arch/riscv/boot/dts/thead/th1520.dtsi
+++ b/arch/riscv/boot/dts/thead/th1520.dtsi
@@ -139,6 +139,7 @@ soc {
 		interrupt-parent = <&plic>;
 		#address-cells = <2>;
 		#size-cells = <2>;
+		dma-noncoherent;
 		ranges;
 
 		plic: interrupt-controller@ffd8000000 {
-- 
2.40.1

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by patchwork-bot+linux-riscv@kernel.org 2 years, 1 month ago

Hello:

This patch was applied to riscv/linux.git (fixes)
by Arnd Bergmann <arnd@arndb.de>:

On Tue, 12 Sep 2023 15:22:32 +0800 you wrote:
> riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> dma coherent, so set dma-noncoherent to reflect this fact.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Tested-by: Drew Fustini <dfustini@baylibre.com>
> ---
> 
> [...]

Here is the summary with links:
  - [v2] riscv: dts: thead: set dma-noncoherent to soc bus
    https://git.kernel.org/riscv/c/759426c758c7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Conor Dooley 2 years, 3 months ago

On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> dma coherent, so set dma-noncoherent to reflect this fact.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Tested-by: Drew Fustini <dfustini@baylibre.com>
> ---
> 
> Since v1:
>  - rebase on v6.6-rc1
>  - collect Tested-by tag

Does this mean you're expecting me to take this?

> 
>  arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index ce708183b6f6..ff364709a6df 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -139,6 +139,7 @@ soc {
>  		interrupt-parent = <&plic>;
>  		#address-cells = <2>;
>  		#size-cells = <2>;
> +		dma-noncoherent;
>  		ranges;
>  
>  		plic: interrupt-controller@ffd8000000 {
> -- 
> 2.40.1
>

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Jisheng Zhang 2 years, 3 months ago

On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > dma coherent, so set dma-noncoherent to reflect this fact.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > ---
> > 
> > Since v1:
> >  - rebase on v6.6-rc1
> >  - collect Tested-by tag
> 
> Does this mean you're expecting me to take this?

Hi Conor,

I think I will take this and send PR to soc people. The reason
I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
mailist due to typo;

Thank you so much
> 
> > 
> >  arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> > index ce708183b6f6..ff364709a6df 100644
> > --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> > @@ -139,6 +139,7 @@ soc {
> >  		interrupt-parent = <&plic>;
> >  		#address-cells = <2>;
> >  		#size-cells = <2>;
> > +		dma-noncoherent;
> >  		ranges;
> >  
> >  		plic: interrupt-controller@ffd8000000 {
> > -- 
> > 2.40.1
> >

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Conor Dooley 2 years, 3 months ago

On Wed, Sep 13, 2023 at 11:15:57PM +0800, Jisheng Zhang wrote:
> On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> > On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > dma coherent, so set dma-noncoherent to reflect this fact.
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > > ---
> > > 
> > > Since v1:
> > >  - rebase on v6.6-rc1
> > >  - collect Tested-by tag
> > 
> > Does this mean you're expecting me to take this?
> 
> Hi Conor,
> 
> I think I will take this and send PR to soc people. The reason
> I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
> mailist due to typo;

Great, thanks. Please ask SFR to add your tree to linux-next.

Cheers,
Conor.

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Conor Dooley 2 years, 2 months ago

Hey Jisheng,

On Wed, Sep 13, 2023 at 04:44:18PM +0100, Conor Dooley wrote:
> On Wed, Sep 13, 2023 at 11:15:57PM +0800, Jisheng Zhang wrote:
> > On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> > > On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > > dma coherent, so set dma-noncoherent to reflect this fact.
> > > > 
> > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > > > ---
> > > > 
> > > > Since v1:
> > > >  - rebase on v6.6-rc1
> > > >  - collect Tested-by tag
> > > 
> > > Does this mean you're expecting me to take this?
> > 
> > Hi Conor,
> > 
> > I think I will take this and send PR to soc people. The reason
> > I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
> > mailist due to typo;
> 
> Great, thanks. Please ask SFR to add your tree to linux-next.

I lost my main x86 box over the weekend (looks like probably a dead
motherboard), so I may have missed a response to this.

Did you see this email? Additionally, can you add that git tree to the
maintainers entry for the thead devicetrees?

Thanks,
Conor.

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Jisheng Zhang 2 years, 2 months ago

On Wed, Sep 20, 2023 at 09:36:19AM +0100, Conor Dooley wrote:
> Hey Jisheng,
> 
> On Wed, Sep 13, 2023 at 04:44:18PM +0100, Conor Dooley wrote:
> > On Wed, Sep 13, 2023 at 11:15:57PM +0800, Jisheng Zhang wrote:
> > > On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> > > > On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > > > dma coherent, so set dma-noncoherent to reflect this fact.
> > > > > 
> > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > > > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > > > > ---
> > > > > 
> > > > > Since v1:
> > > > >  - rebase on v6.6-rc1
> > > > >  - collect Tested-by tag
> > > > 
> > > > Does this mean you're expecting me to take this?
> > > 
> > > Hi Conor,
> > > 
> > > I think I will take this and send PR to soc people. The reason
> > > I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
> > > mailist due to typo;
> > 
> > Great, thanks. Please ask SFR to add your tree to linux-next.

Hi Conor,

I'm not sure how to do this. When MAINTAINERS patch is merged, send
an email to Stephen Rothwell, are these steps correct?

> 
> I lost my main x86 box over the weekend (looks like probably a dead
> motherboard), so I may have missed a response to this.
> 
> Did you see this email? Additionally, can you add that git tree to the
> maintainers entry for the thead devicetrees?

I just created a tree in
git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git

But it needs time for cgit to take place. I will send a patch
once it appears.

Thanks

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Conor Dooley 2 years, 2 months ago

On Thu, Sep 21, 2023 at 05:24:57PM +0800, Jisheng Zhang wrote:
> On Wed, Sep 20, 2023 at 09:36:19AM +0100, Conor Dooley wrote:
> > Hey Jisheng,
> > 
> > On Wed, Sep 13, 2023 at 04:44:18PM +0100, Conor Dooley wrote:
> > > On Wed, Sep 13, 2023 at 11:15:57PM +0800, Jisheng Zhang wrote:
> > > > On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> > > > > On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > > > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > > > > dma coherent, so set dma-noncoherent to reflect this fact.
> > > > > > 
> > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > > > > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > > > > > ---
> > > > > > 
> > > > > > Since v1:
> > > > > >  - rebase on v6.6-rc1
> > > > > >  - collect Tested-by tag
> > > > > 
> > > > > Does this mean you're expecting me to take this?
> > > > 
> > > > Hi Conor,
> > > > 
> > > > I think I will take this and send PR to soc people. The reason
> > > > I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
> > > > mailist due to typo;
> > > 
> > > Great, thanks. Please ask SFR to add your tree to linux-next.
> 
> Hi Conor,
> 
> I'm not sure how to do this. When MAINTAINERS patch is merged, send
> an email to Stephen Rothwell, are these steps correct?

Sorta, yeah. You don't need to have the MAINTAINERS patch merged first
though, just send him a link to your tree and the branch name(s) & he
will include it in linux-next.

> > I lost my main x86 box over the weekend (looks like probably a dead
> > motherboard), so I may have missed a response to this.
> > 
> > Did you see this email? Additionally, can you add that git tree to the
> > maintainers entry for the thead devicetrees?
> 
> I just created a tree in
> git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git
> 
> But it needs time for cgit to take place. I will send a patch
> once it appears.

Looks to be there for me now. Thanks for doing this!

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Drew Fustini 2 years, 2 months ago

On Thu, Sep 21, 2023 at 11:08:28AM +0100, Conor Dooley wrote:
> On Thu, Sep 21, 2023 at 05:24:57PM +0800, Jisheng Zhang wrote:
> > On Wed, Sep 20, 2023 at 09:36:19AM +0100, Conor Dooley wrote:
> > > Hey Jisheng,
> > > 
> > > On Wed, Sep 13, 2023 at 04:44:18PM +0100, Conor Dooley wrote:
> > > > On Wed, Sep 13, 2023 at 11:15:57PM +0800, Jisheng Zhang wrote:
> > > > > On Tue, Sep 12, 2023 at 05:27:31PM +0100, Conor Dooley wrote:
> > > > > > On Tue, Sep 12, 2023 at 03:22:32PM +0800, Jisheng Zhang wrote:
> > > > > > > riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> > > > > > > dma coherent, so set dma-noncoherent to reflect this fact.
> > > > > > > 
> > > > > > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > > > > > Tested-by: Drew Fustini <dfustini@baylibre.com>
> > > > > > > ---
> > > > > > > 
> > > > > > > Since v1:
> > > > > > >  - rebase on v6.6-rc1
> > > > > > >  - collect Tested-by tag
> > > > > > 
> > > > > > Does this mean you're expecting me to take this?
> > > > > 
> > > > > Hi Conor,
> > > > > 
> > > > > I think I will take this and send PR to soc people. The reason
> > > > > I send v2 is the rebasing on new rc1 and v1 wasn't in linux-riscv
> > > > > mailist due to typo;
> > > > 
> > > > Great, thanks. Please ask SFR to add your tree to linux-next.
> > 
> > Hi Conor,
> > 
> > I'm not sure how to do this. When MAINTAINERS patch is merged, send
> > an email to Stephen Rothwell, are these steps correct?
> 
> Sorta, yeah. You don't need to have the MAINTAINERS patch merged first
> though, just send him a link to your tree and the branch name(s) & he
> will include it in linux-next.
> 
> > > I lost my main x86 box over the weekend (looks like probably a dead
> > > motherboard), so I may have missed a response to this.
> > > 
> > > Did you see this email? Additionally, can you add that git tree to the
> > > maintainers entry for the thead devicetrees?
> > 
> > I just created a tree in
> > git://git.kernel.org/pub/scm/linux/kernel/git/jszhang/linux.git
> > 
> > But it needs time for cgit to take place. I will send a patch
> > once it appears.
> 
> Looks to be there for me now. Thanks for doing this!

Hi Jisheng, I'm writing the cover letter for v2 of my th1520 mmc series
and I am wondering if this dma-noncoherent patch is in any tree yet?

Thanks,
Drew

Re: [PATCH v2] riscv: dts: thead: set dma-noncoherent to soc bus

Posted by Guo Ren 2 years, 3 months ago

On Tue, Sep 12, 2023 at 3:34 PM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> riscv select ARCH_DMA_DEFAULT_COHERENT by default, and th1520 isn't
> dma coherent, so set dma-noncoherent to reflect this fact.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Tested-by: Drew Fustini <dfustini@baylibre.com>
> ---
>
> Since v1:
>  - rebase on v6.6-rc1
>  - collect Tested-by tag
>
>  arch/riscv/boot/dts/thead/th1520.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
> index ce708183b6f6..ff364709a6df 100644
> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
> @@ -139,6 +139,7 @@ soc {
>                 interrupt-parent = <&plic>;
>                 #address-cells = <2>;
>                 #size-cells = <2>;
> +               dma-noncoherent;
Reviewed-by: Guo Ren <guoren@kernel.org>

>                 ranges;
>
>                 plic: interrupt-controller@ffd8000000 {
> --
> 2.40.1
>


-- 
Best Regards
 Guo Ren