[v2] hwrng: stm32: support STM32MP13x platforms

[PATCH v2 07/10] dt-bindings: rng: add st,rng-lock-conf

Posted by Gatien Chevallier 2 years, 3 months ago

If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
and RNG_NSCR will be locked. It is supported starting from the RNG
version present in the STM32MP13

Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
---
 .../devicetree/bindings/rng/st,stm32-rng.yaml      | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
index 59abdc85a9fb..0055f14a8e3f 100644
--- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
+++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml
@@ -37,6 +37,20 @@ required:
   - reg
   - clocks
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - st,stm32mp13-rng
+    then:
+      properties:
+        st,rng-lock-conf:
+          type: boolean
+          description: If set, the RNG configuration in RNG_CR, RNG_HTCR and
+                       RNG_NSCR will be locked.
+
 additionalProperties: false
 
 examples:
-- 
2.25.1

Re: [PATCH v2 07/10] dt-bindings: rng: add st,rng-lock-conf

Posted by Krzysztof Kozlowski 2 years, 3 months ago

On 11/09/2023 14:02, Gatien Chevallier wrote:
> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
> and RNG_NSCR will be locked. It is supported starting from the RNG
> version present in the STM32MP13
> 
> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>

How did you implement the comment? There is no changelog, so was it ignored?

Best regards,
Krzysztof

Re: [PATCH v2 07/10] dt-bindings: rng: add st,rng-lock-conf

Posted by Gatien CHEVALLIER 2 years, 3 months ago

On 9/12/23 16:38, Krzysztof Kozlowski wrote:
> On 11/09/2023 14:02, Gatien Chevallier wrote:
>> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
>> and RNG_NSCR will be locked. It is supported starting from the RNG
>> version present in the STM32MP13
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> 
> How did you implement the comment? There is no changelog, so was it ignored?
> 
> Best regards,
> Krzysztof
> 

Hello Krzysztof,

I've sent V2 before Rob's review. I'll apply Rob's comment for V3.

Best regards,
Gatien

Re: [PATCH v2 07/10] dt-bindings: rng: add st,rng-lock-conf

Posted by Krzysztof Kozlowski 2 years, 3 months ago

On 13/09/2023 09:48, Gatien CHEVALLIER wrote:
> On 9/12/23 16:38, Krzysztof Kozlowski wrote:
>> On 11/09/2023 14:02, Gatien Chevallier wrote:
>>> If st,rng-lock-conf is set, the RNG configuration in RNG_CR, RNG_HTCR
>>> and RNG_NSCR will be locked. It is supported starting from the RNG
>>> version present in the STM32MP13
>>>
>>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>>
>> How did you implement the comment? There is no changelog, so was it ignored?
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hello Krzysztof,
> 
> I've sent V2 before Rob's review. I'll apply Rob's comment for V3.

Ah, ok.

Best regards,
Krzysztof