coresight: etm4x: Add ACPI id for THEAD YiTian SOC

[PATCH] coresight: etm4x: Add ACPI id for THEAD YiTian SOC

Posted by Ruidong Tian 2 years, 3 months ago

From: Jay Chen <jkchen@linux.alibaba.com>

Add support for detcting ETE device of THEAD YiTian SOC.

Signed-off-by: Jay Chen <jkchen@linux.alibaba.com>
Signed-off-by: Ruidong Tian <tianruidong@linux.alibaba.com>
---
 drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
index 77b0271ce6eb..329bb554b168 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
@@ -2351,6 +2351,7 @@ static const struct of_device_id etm4_sysreg_match[] = {
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id etm4x_acpi_ids[] = {
 	{"ARMHC500", 0}, /* ARM CoreSight ETM4x */
+	{"BABA6000", 0 }, /* THEAD CoreSight ETE */
 	{}
 };
 MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids);
-- 
2.33.1

Re: [PATCH] coresight: etm4x: Add ACPI id for THEAD YiTian SOC

Posted by Sudeep Holla 2 years, 3 months ago

On Mon, Sep 11, 2023 at 03:25:09PM +0800, Ruidong Tian wrote:
> From: Jay Chen <jkchen@linux.alibaba.com>
> 
> Add support for detcting ETE device of THEAD YiTian SOC.
>

Are you trying to identify "THEAD YiTian" SoC here ? Or the standard
ARM Coresight ETMv4 ? Or does this THEAD YiTian SoC has a modified version
of ETMv4 which needs special handling in the driver ?

-- 
Regards,
Sudeep

Re: [PATCH] coresight: etm4x: Add ACPI id for THEAD YiTian SOC

Posted by Suzuki K Poulose 2 years, 3 months ago

On 11/09/2023 08:25, Ruidong Tian wrote:
> From: Jay Chen <jkchen@linux.alibaba.com>
> 
> Add support for detcting ETE device of THEAD YiTian SOC.
> 
> Signed-off-by: Jay Chen <jkchen@linux.alibaba.com>
> Signed-off-by: Ruidong Tian <tianruidong@linux.alibaba.com>
> ---
>   drivers/hwtracing/coresight/coresight-etm4x-core.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> index 77b0271ce6eb..329bb554b168 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c
> @@ -2351,6 +2351,7 @@ static const struct of_device_id etm4_sysreg_match[] = {
>   #ifdef CONFIG_ACPI
>   static const struct acpi_device_id etm4x_acpi_ids[] = {
>   	{"ARMHC500", 0}, /* ARM CoreSight ETM4x */
> +	{"BABA6000", 0 }, /* THEAD CoreSight ETE */

Why don't we use ARMHC500 for the ETE ? See :

https://developer.arm.com/documentation/den0067/latest/

Suzuki


>   	{}
>   };
>   MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids);