[v1] ASoC: dwc: fix typo in comment

[PATCH] ASoC: dwc: fix typo in comment

Posted by Myunguk Kim 2 years, 3 months ago

This fixes typo in comment

Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
---
 sound/soc/dwc/dwc-i2s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index 71ff894035a4..45e55e550924 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
 			irq_valid = true;
 		}
 
-		/* Error Handling: TX */
+		/* Error Handling: RX */
 		if (isr[i] & ISR_RXFO) 
{ 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
 			irq_valid = true;
-- 
2.34.1

Re: [PATCH] ASoC: dwc: fix typo in comment

Posted by Mark Brown 2 years, 3 months ago

On Mon, Sep 11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:
> This fixes typo in comment
> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>

This doesn't apply against current code, please check and resend:

Applying: ASoC: dwc: fix typo in comment
error: sha1 information is lacking or useless (sound/soc/dwc/dwc-i2s.c).
error: could not build fake ancestor
Patch failed at 0001 ASoC: dwc: fix typo in comment

(after fixing what looked like corruption in the mail)

Re: [PATCH] ASoC: dwc: fix typo in comment

Posted by Myunguk Kim 2 years, 3 months ago

> This doesn't apply against current code, please check and resend:

Sorry, I will send a clean v2 in a moment.

Re: [PATCH] ASoC: dwc: fix typo in comment

Posted by Maxim Kochetkov 2 years, 3 months ago


On 11.09.2023 09:46, Myunguk Kim wrote:
> This fixes typo in comment
> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>

Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>

Re: [PATCH] ASoC: dwc: fix typo in comment

Posted by Bagas Sanjaya 2 years, 3 months ago

On Mon, Sep 11, 2023 at 03:46:46PM +0900, Myunguk Kim wrote:
> This fixes typo in comment

On what? Can you describe the typofix in more detail?

> 
> Signed-off-by: Myunguk Kim <mwkim@gaonchips.com>
> ---
>  sound/soc/dwc/dwc-i2s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
> index 71ff894035a4..45e55e550924 100644
> --- a/sound/soc/dwc/dwc-i2s.c
> +++ b/sound/soc/dwc/dwc-i2s.c
> @@ -138,7 +138,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *dev_id)
>  			irq_valid = true;
>  		}
>  
> -		/* Error Handling: TX */
> +		/* Error Handling: RX */
>  		if (isr[i] & ISR_RXFO) 
> { 			dev_err_ratelimited(dev->dev, "RX overrun (ch_id=%d)\n", i);
>  			irq_valid = true;

Oh, you mean the code following the comment checks for RXFO overrun.

Confused...

-- 
An old man doll... just what I always wanted! - Clara