[v3] Power: T7: add power domain driver

[PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Xianwei Zhao 2 years, 3 months ago

First patch is that remove C3 some power domain ALWAYS_ON property.
Second patch is that add driver to support power parent node. 
Third patch is that turn on power if initial power domain with
"AWAY_ON" property state is off.

Other patchs adds power controller driver support for Amlogic T7 SoC.

Changes Since v2:
 -Modify subject.
 -Define PWRC_NO_PARENT UINT_MAX
 -Remove modification that transform is_off into 1 or 0 using !!

Changes Since v1:
 -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
 -Modify T7_NIC flag  "ALWAYS_ON"

xianwei.zhao (6):
  genpd: amlogic: modify some power domains property
  genpd: amlogic: add driver to support power parent node
  genpd: amlogic: init power domain state
  dt-bindings: power: add Amlogic T7 power domains
  genpd: amlogic: Add support for T7 power domains controller
  arm64: dts: amlogic: t7: add power domain controller node

 .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
 drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
 include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
 4 files changed, 185 insertions(+), 14 deletions(-)
 create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h


base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
-- 
2.37.1

Re: [PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Ulf Hansson 2 years, 3 months ago

On Mon, 11 Sept 2023 at 04:52, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
> First patch is that remove C3 some power domain ALWAYS_ON property.
> Second patch is that add driver to support power parent node.
> Third patch is that turn on power if initial power domain with
> "AWAY_ON" property state is off.
>
> Other patchs adds power controller driver support for Amlogic T7 SoC.
>
> Changes Since v2:
>  -Modify subject.
>  -Define PWRC_NO_PARENT UINT_MAX
>  -Remove modification that transform is_off into 1 or 0 using !!
>
> Changes Since v1:
>  -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
>  -Modify T7_NIC flag  "ALWAYS_ON"
>
> xianwei.zhao (6):
>   genpd: amlogic: modify some power domains property
>   genpd: amlogic: add driver to support power parent node
>   genpd: amlogic: init power domain state
>   dt-bindings: power: add Amlogic T7 power domains
>   genpd: amlogic: Add support for T7 power domains controller
>   arm64: dts: amlogic: t7: add power domain controller node
>
>  .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
>  arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
>  drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
>  include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
>  4 files changed, 185 insertions(+), 14 deletions(-)
>  create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h
>
>
> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
> --
> 2.37.1
>

Patch 1 to 5, applied for next!

The DT patch (patch4), is available on an immutable branch "genpd_dt" too.

From now on, I will continue to put changes for genpd DT bindings on
the above branch, to allow SoC maintainers to pull it in to manage
potential dependent updates to DTS files.

Kind regards
Uffe

Re: [PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Neil Armstrong 2 years, 3 months ago

On 11/09/2023 16:30, Ulf Hansson wrote:
> On Mon, 11 Sept 2023 at 04:52, Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>>
>> First patch is that remove C3 some power domain ALWAYS_ON property.
>> Second patch is that add driver to support power parent node.
>> Third patch is that turn on power if initial power domain with
>> "AWAY_ON" property state is off.
>>
>> Other patchs adds power controller driver support for Amlogic T7 SoC.
>>
>> Changes Since v2:
>>   -Modify subject.
>>   -Define PWRC_NO_PARENT UINT_MAX
>>   -Remove modification that transform is_off into 1 or 0 using !!
>>
>> Changes Since v1:
>>   -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
>>   -Modify T7_NIC flag  "ALWAYS_ON"
>>
>> xianwei.zhao (6):
>>    genpd: amlogic: modify some power domains property
>>    genpd: amlogic: add driver to support power parent node
>>    genpd: amlogic: init power domain state
>>    dt-bindings: power: add Amlogic T7 power domains
>>    genpd: amlogic: Add support for T7 power domains controller
>>    arm64: dts: amlogic: t7: add power domain controller node
>>
>>   .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
>>   drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
>>   include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
>>   4 files changed, 185 insertions(+), 14 deletions(-)
>>   create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h
>>
>>
>> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
>> --
>> 2.37.1
>>
> 
> Patch 1 to 5, applied for next!
> 
> The DT patch (patch4), is available on an immutable branch "genpd_dt" too.
> 
>  From now on, I will continue to put changes for genpd DT bindings on
> the above branch, to allow SoC maintainers to pull it in to manage
> potential dependent updates to DTS files.

Thanks, let's see how it works :-)

Neil

> 
> Kind regards
> Uffe

Re: (subset) [PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Neil Armstrong 2 years, 3 months ago

Hi,

On Mon, 11 Sep 2023 10:52:17 +0800, Xianwei Zhao wrote:
> First patch is that remove C3 some power domain ALWAYS_ON property.
> Second patch is that add driver to support power parent node.
> Third patch is that turn on power if initial power domain with
> "AWAY_ON" property state is off.
> 
> Other patchs adds power controller driver support for Amlogic T7 SoC.
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/arm64-dt)

[6/6] arm64: dts: amlogic: t7: add power domain controller node
      https://git.kernel.org/amlogic/c/5355699dabac3c97492a30e6e01820fcaae11218

These changes has been applied on the intermediate git tree [1].

The v6.7/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil

Re: (subset) [PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Lucas Tanure 2 years, 2 months ago

On 11-09-2023 16:09, Neil Armstrong wrote:
> Hi,
> 
> On Mon, 11 Sep 2023 10:52:17 +0800, Xianwei Zhao wrote:
>> First patch is that remove C3 some power domain ALWAYS_ON property.
>> Second patch is that add driver to support power parent node.
>> Third patch is that turn on power if initial power domain with
>> "AWAY_ON" property state is off.
>>
>> Other patchs adds power controller driver support for Amlogic T7 SoC.
>>
>> [...]
> 
> Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/arm64-dt)
> 
> [6/6] arm64: dts: amlogic: t7: add power domain controller node
>        https://git.kernel.org/amlogic/c/5355699dabac3c97492a30e6e01820fcaae11218
> 
> These changes has been applied on the intermediate git tree [1].
> 
> The v6.7/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
> for inclusion in their intermediate git branches in order to be sent to Linus during
> the next merge window, or sooner if it's a set of fixes.
> 
> In the cases of fixes, those will be merged in the current release candidate
> kernel and as soon they appear on the Linux master branch they will be
> backported to the previous Stable and Long-Stable kernels [2].
> 
> The intermediate git branches are merged daily in the linux-next tree [3],
> people are encouraged testing these pre-release kernels and report issues on the
> relevant mailing-lists.
> 
> If problems are discovered on those changes, please submit a signed-off-by revert
> patch followed by a corrective changeset.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> 
I re-tested this today with Vim4 and works fine.
By works I mean, vim4 is able to boot without panics but drops to 
emergency shell as expected.

I was not able to find patches 1-3 and 5 at amlogic/for-next.
Is there a reason why amlogic/for-next only have DTs changes?

Tested-by: Lucas Tanure <tanure@linux.com>

Re: (subset) [PATCH V3 RESEND 0/6] Power: T7: add power domain driver

Posted by Neil Armstrong 2 years, 2 months ago

Hi Lucas,

Le 27/09/2023 à 08:05, Lucas Tanure a écrit :
> On 11-09-2023 16:09, Neil Armstrong wrote:
>> Hi,
>>
>> On Mon, 11 Sep 2023 10:52:17 +0800, Xianwei Zhao wrote:
>>> First patch is that remove C3 some power domain ALWAYS_ON property.
>>> Second patch is that add driver to support power parent node.
>>> Third patch is that turn on power if initial power domain with
>>> "AWAY_ON" property state is off.
>>>
>>> Other patchs adds power controller driver support for Amlogic T7 SoC.
>>>
>>> [...]
>>
>> Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/arm64-dt)
>>
>> [6/6] arm64: dts: amlogic: t7: add power domain controller node
>>        https://git.kernel.org/amlogic/c/5355699dabac3c97492a30e6e01820fcaae11218
>>
>> These changes has been applied on the intermediate git tree [1].
>>
>> The v6.7/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
>> for inclusion in their intermediate git branches in order to be sent to Linus during
>> the next merge window, or sooner if it's a set of fixes.
>>
>> In the cases of fixes, those will be merged in the current release candidate
>> kernel and as soon they appear on the Linux master branch they will be
>> backported to the previous Stable and Long-Stable kernels [2].
>>
>> The intermediate git branches are merged daily in the linux-next tree [3],
>> people are encouraged testing these pre-release kernels and report issues on the
>> relevant mailing-lists.
>>
>> If problems are discovered on those changes, please submit a signed-off-by revert
>> patch followed by a corrective changeset.
>>
>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
>> [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
>> [3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>>
> I re-tested this today with Vim4 and works fine.
> By works I mean, vim4 is able to boot without panics but drops to emergency shell as expected.
> 
> I was not able to find patches 1-3 and 5 at amlogic/for-next.
> Is there a reason why amlogic/for-next only have DTs changes?

 From now I'll only take the DT and the genpd/ changes will go into the new
subsystem maintained by Ulf.

You should use the daily linux-next tree which would contain both trees merged.

Thanks,
Neil

> 
> Tested-by: Lucas Tanure <tanure@linux.com>
> 
> 
>