[v1] fs/proc: do_task_stat: use __for_each_thread()

[PATCH] fs/proc: do_task_stat: use __for_each_thread()

Oleg Nesterov posted 1 patch 2 years, 3 months ago

Diff against v1 v1 v1 v1
Download mbox

There is a newer version of this series

fs/proc/array.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] fs/proc: do_task_stat: use __for_each_thread()

Posted by Oleg Nesterov 2 years, 3 months ago

do/while_each_thread should be avoided when possible.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 fs/proc/array.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index 2c2efbe685d8..ff08a8957552 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -536,12 +536,13 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
 
 		/* add up live thread stats at the group level */
 		if (whole) {
-			struct task_struct *t = task;
-			do {
+			struct task_struct *t;
+
+			__for_each_thread(sig, t) {
 				min_flt += t->min_flt;
 				maj_flt += t->maj_flt;
 				gtime += task_gtime(t);
-			} while_each_thread(task, t);
+			}
 
 			min_flt += sig->min_flt;
 			maj_flt += sig->maj_flt;
-- 
2.25.1.362.g51ebf55