Documentation: Process: Add a note about git way of applying patch

[PATCH] Documentation: Process: Add a note about git way of applying patch

Posted by Bhaskar Chowdhury 2 years, 3 months ago

cc: jesper.juhl@gmail.com

Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
 Documentation/process/applying-patches.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
index c269f5e1a0a3..201b9900bffe 100644
--- a/Documentation/process/applying-patches.rst
+++ b/Documentation/process/applying-patches.rst
@@ -6,6 +6,13 @@ Applying Patches To The Linux Kernel
 Original by:
 	Jesper Juhl, August 2005

+
+.. applying patch by Git::
+
+    You can use the below syntax to patch in git repository
+    git-apply --whitespace=error-all <patchfile>
+
+
 .. note::

    This document is obsolete.  In most cases, rather than using ``patch``
--
2.41.0

Re: [PATCH] Documentation: Process: Add a note about git way of applying patch

Posted by Jonathan Corbet 2 years, 3 months ago

Bhaskar Chowdhury <unixbhaskar@gmail.com> writes:

> cc: jesper.juhl@gmail.com
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
>  Documentation/process/applying-patches.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
> index c269f5e1a0a3..201b9900bffe 100644
> --- a/Documentation/process/applying-patches.rst
> +++ b/Documentation/process/applying-patches.rst
> @@ -6,6 +6,13 @@ Applying Patches To The Linux Kernel
>  Original by:
>  	Jesper Juhl, August 2005
>
> +
> +.. applying patch by Git::
> +
> +    You can use the below syntax to patch in git repository
> +    git-apply --whitespace=error-all <patchfile>
> +
> +
>  .. note::
>
>     This document is obsolete.  In most cases, rather than using ``patch``

So why are you sending a patch ... with no changelog ... adding a
useless label ... and Sphinx syntax errors ... to a document that is
explicitly marked as being obsolete?

jon

Re: [PATCH] Documentation: Process: Add a note about git way of applying patch

Posted by Bhaskar Chowdhury 2 years, 3 months ago

On 06:48 Thu 07 Sep 2023, Jonathan Corbet wrote:
>Bhaskar Chowdhury <unixbhaskar@gmail.com> writes:
>
>> cc: jesper.juhl@gmail.com
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  Documentation/process/applying-patches.rst | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
>> index c269f5e1a0a3..201b9900bffe 100644
>> --- a/Documentation/process/applying-patches.rst
>> +++ b/Documentation/process/applying-patches.rst
>> @@ -6,6 +6,13 @@ Applying Patches To The Linux Kernel
>>  Original by:
>>  	Jesper Juhl, August 2005
>>
>> +
>> +.. applying patch by Git::
>> +
>> +    You can use the below syntax to patch in git repository
>> +    git-apply --whitespace=error-all <patchfile>
>> +
>> +
>>  .. note::
>>
>>     This document is obsolete.  In most cases, rather than using ``patch``
>
>So why are you sending a patch ... with no changelog

My bad. Realized it once send it.


>to a document that is explicitly marked as being obsolete?

I thought if people visit that page , that note might help.

Are we taking out that page from the doc? Why that page is still there?


>jon

--
Thanks,
Bhaskar

"Here's looking at you kid"-- Casablanca
https://about.me/unixbhaskar

Re: [PATCH] Documentation: Process: Add a note about git way of applying patch

Posted by Jonathan Corbet 2 years, 3 months ago

Bhaskar Chowdhury <unixbhaskar@gmail.com> writes:

> On 06:48 Thu 07 Sep 2023, Jonathan Corbet wrote:
>>Bhaskar Chowdhury <unixbhaskar@gmail.com> writes:
>>
>>> cc: jesper.juhl@gmail.com
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>>  Documentation/process/applying-patches.rst | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/Documentation/process/applying-patches.rst b/Documentation/process/applying-patches.rst
>>> index c269f5e1a0a3..201b9900bffe 100644
>>> --- a/Documentation/process/applying-patches.rst
>>> +++ b/Documentation/process/applying-patches.rst
>>> @@ -6,6 +6,13 @@ Applying Patches To The Linux Kernel
>>>  Original by:
>>>  	Jesper Juhl, August 2005
>>>
>>> +
>>> +.. applying patch by Git::
>>> +
>>> +    You can use the below syntax to patch in git repository
>>> +    git-apply --whitespace=error-all <patchfile>
>>> +
>>> +
>>>  .. note::
>>>
>>>     This document is obsolete.  In most cases, rather than using ``patch``
>>
>>So why are you sending a patch ... with no changelog
>
> My bad. Realized it once send it.
>
>
>>to a document that is explicitly marked as being obsolete?
>
> I thought if people visit that page , that note might help.
>
> Are we taking out that page from the doc? Why that page is still there?

I would happily remove it, but ran into resistance (a few years ago)
when I suggested it.

Thanks,

jon