[PATCH] arm64: dts: qcom: sdx75-idp: align RPMh regulator nodes with bindings

Krzysztof Kozlowski posted 1 patch 2 years, 5 months ago
arch/arm64/boot/dts/qcom/sdx75-idp.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] arm64: dts: qcom: sdx75-idp: align RPMh regulator nodes with bindings
Posted by Krzysztof Kozlowski 2 years, 5 months ago
Device node names should be generic and bindings expect certain pattern
for RPMh regulator nodes:

  sdx75-idp.dtb: rsc@17a00000: 'pmx75-rpmh-regulators' does not match any of the regexes: '^regulators(-[0-9])?$', 'pinctrl-[0-9]+'

Fixes: 8a2dc39d1043 ("arm64: dts: qcom: sdx75-idp: Add regulator nodes")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Really, I can't believe I am still fixing this stuff. New boards bring
the same mistakes we fixed half year ago. Or even earlier...
---
 arch/arm64/boot/dts/qcom/sdx75-idp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
index 10d15871f2c4..a14e0650c4a8 100644
--- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
@@ -44,7 +44,7 @@ vreg_bob_3p3: pmx75-bob {
 };
 
 &apps_rsc {
-	pmx75-rpmh-regulators {
+	regulators-0 {
 		compatible = "qcom,pmx75-rpmh-regulators";
 		qcom,pmic-id = "b";
 
-- 
2.34.1
Re: [PATCH] arm64: dts: qcom: sdx75-idp: align RPMh regulator nodes with bindings
Posted by Bjorn Andersson 2 years, 4 months ago
On Tue, 05 Sep 2023 18:31:03 +0200, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes:
> 
>   sdx75-idp.dtb: rsc@17a00000: 'pmx75-rpmh-regulators' does not match any of the regexes: '^regulators(-[0-9])?$', 'pinctrl-[0-9]+'
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sdx75-idp: align RPMh regulator nodes with bindings
      commit: 815ea491460766dbd4b39a3c9904b44b5880c41c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] arm64: dts: qcom: sdx75-idp: align RPMh regulator nodes with bindings
Posted by Konrad Dybcio 2 years, 5 months ago
On 5.09.2023 18:31, Krzysztof Kozlowski wrote:
> Device node names should be generic and bindings expect certain pattern
> for RPMh regulator nodes:
> 
>   sdx75-idp.dtb: rsc@17a00000: 'pmx75-rpmh-regulators' does not match any of the regexes: '^regulators(-[0-9])?$', 'pinctrl-[0-9]+'
> 
> Fixes: 8a2dc39d1043 ("arm64: dts: qcom: sdx75-idp: Add regulator nodes")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

> 
> Really, I can't believe I am still fixing this stuff. New boards bring
> the same mistakes we fixed half year ago. Or even earlier...
> ---
Can't stop overlooking these!

Konrad