[PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current

Krzysztof Kozlowski posted 12 patches 2 years, 5 months ago
[PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current
Posted by Krzysztof Kozlowski 2 years, 5 months ago
Neither bindings nor UFS phy driver use properties like
'vdda-phy-max-microamp' and 'vdda-pll-max-microamp':

  sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
index 272bc85f1719..90b5f22ea9dc 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
+++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts
@@ -406,8 +406,6 @@ &ufs_mem_hc {
 &ufs_mem_phy {
 	vdda-phy-supply = <&vreg_l4a>;
 	vdda-pll-supply = <&vreg_l10a>;
-	vdda-phy-max-microamp = <51400>;
-	vdda-pll-max-microamp = <14200>;
 	vddp-ref-clk-supply = <&vreg_l18a>;
 	status = "okay";
 };
-- 
2.34.1
Re: [PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current
Posted by Konrad Dybcio 2 years, 5 months ago
On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
> Neither bindings nor UFS phy driver use properties like
> 'vdda-phy-max-microamp' and 'vdda-pll-max-microamp':
> 
>   sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
ufshcd_populate_vreg uses this, but looks like nobody added it
to bindings.

Konrad
Re: [PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current
Posted by Krzysztof Kozlowski 2 years, 5 months ago
On 06/09/2023 11:40, Konrad Dybcio wrote:
> On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
>> Neither bindings nor UFS phy driver use properties like
>> 'vdda-phy-max-microamp' and 'vdda-pll-max-microamp':
>>
>>   sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> ufshcd_populate_vreg uses this, but looks like nobody added it
> to bindings.

That's UFS controller, not phy. I do not see any usage of it in the phy.

Best regards,
Krzysztof
Re: [PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current
Posted by Konrad Dybcio 2 years, 5 months ago
On 6.09.2023 11:45, Krzysztof Kozlowski wrote:
> On 06/09/2023 11:40, Konrad Dybcio wrote:
>> On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
>>> Neither bindings nor UFS phy driver use properties like
>>> 'vdda-phy-max-microamp' and 'vdda-pll-max-microamp':
>>>
>>>   sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>> ufshcd_populate_vreg uses this, but looks like nobody added it
>> to bindings.
> 
> That's UFS controller, not phy. I do not see any usage of it in the phy.
Oh right..

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad