[PATCH] fbdev/g364fb: fix build failure with mips

Sudip Mukherjee posted 1 patch 2 years, 3 months ago
drivers/video/fbdev/g364fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] fbdev/g364fb: fix build failure with mips
Posted by Sudip Mukherjee 2 years, 3 months ago
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Fix the typo which resulted in the driver using FB_DEFAULT_IOMEM_HELPERS
instead of FB_DEFAULT_IOMEM_OPS as the fbdev I/O helpers.

Fixes: 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
 drivers/video/fbdev/g364fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/g364fb.c
index 7a1013b22fa7..ee6fe51e0a6b 100644
--- a/drivers/video/fbdev/g364fb.c
+++ b/drivers/video/fbdev/g364fb.c
@@ -112,7 +112,7 @@ static int g364fb_blank(int blank, struct fb_info *info);
 
 static const struct fb_ops g364fb_ops = {
 	.owner		= THIS_MODULE,
-	FB_DEFAULT_IOMEM_HELPERS,
+	FB_DEFAULT_IOMEM_OPS,
 	.fb_setcolreg	= g364fb_setcolreg,
 	.fb_pan_display	= g364fb_pan_display,
 	.fb_blank	= g364fb_blank,
-- 
2.39.2
Re: [PATCH] fbdev/g364fb: fix build failure with mips
Posted by Thomas Zimmermann 2 years, 3 months ago
Hi

Am 02.09.23 um 11:51 schrieb Sudip Mukherjee:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> 
> Fix the typo which resulted in the driver using FB_DEFAULT_IOMEM_HELPERS
> instead of FB_DEFAULT_IOMEM_OPS as the fbdev I/O helpers.
> 
> Fixes: 501126083855 ("fbdev/g364fb: Use fbdev I/O helpers")
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

Merged into drm-misc-next-fixes. Thanks for the patch.

Best regards
Thomas

> ---
>   drivers/video/fbdev/g364fb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/g364fb.c b/drivers/video/fbdev/g364fb.c
> index 7a1013b22fa7..ee6fe51e0a6b 100644
> --- a/drivers/video/fbdev/g364fb.c
> +++ b/drivers/video/fbdev/g364fb.c
> @@ -112,7 +112,7 @@ static int g364fb_blank(int blank, struct fb_info *info);
>   
>   static const struct fb_ops g364fb_ops = {
>   	.owner		= THIS_MODULE,
> -	FB_DEFAULT_IOMEM_HELPERS,
> +	FB_DEFAULT_IOMEM_OPS,
>   	.fb_setcolreg	= g364fb_setcolreg,
>   	.fb_pan_display	= g364fb_pan_display,
>   	.fb_blank	= g364fb_blank,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)