[PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry

Biju Das posted 3 patches 2 years, 5 months ago
[PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Biju Das 2 years, 5 months ago
Remove trailing comma in the terminator entry for OF table.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v4:
 * New patch
---
 sound/soc/codecs/wm8580.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c
index 826c39ec4a1e..ba47b01f13e7 100644
--- a/sound/soc/codecs/wm8580.c
+++ b/sound/soc/codecs/wm8580.c
@@ -991,7 +991,7 @@ static const struct wm8580_driver_data wm8581_data = {
 static const struct of_device_id wm8580_of_match[] = {
 	{ .compatible = "wlf,wm8580", .data = &wm8580_data },
 	{ .compatible = "wlf,wm8581", .data = &wm8581_data },
-	{ },
+	{ }
 };
 MODULE_DEVICE_TABLE(of, wm8580_of_match);
 
-- 
2.25.1
Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Andy Shevchenko 2 years, 5 months ago
On Fri, Sep 01, 2023 at 07:59:51AM +0100, Biju Das wrote:
> Remove trailing comma in the terminator entry for OF table.

You are so fast :-)
This will produce an unneeded churn as you touch the same line twice in a row.

Just combine them and mention both changes in the commit message.

With that done,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Mark Brown 2 years, 5 months ago
On Fri, Sep 01, 2023 at 11:53:29AM +0300, Andy Shevchenko wrote:
> On Fri, Sep 01, 2023 at 07:59:51AM +0100, Biju Das wrote:

> > Remove trailing comma in the terminator entry for OF table.

> You are so fast :-)
> This will produce an unneeded churn as you touch the same line twice in a row.

So do reviews which focus on very pedantic issues like this one...
Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Andy Shevchenko 2 years, 5 months ago
On Fri, Sep 01, 2023 at 01:54:58PM +0100, Mark Brown wrote:
> On Fri, Sep 01, 2023 at 11:53:29AM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 01, 2023 at 07:59:51AM +0100, Biju Das wrote:
> 
> > > Remove trailing comma in the terminator entry for OF table.
> 
> > You are so fast :-)
> > This will produce an unneeded churn as you touch the same line twice in a row.
> 
> So do reviews which focus on very pedantic issues like this one...

If you fine with a series as is, take it!
It's really nothing to bikeshed about.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Mark Brown 2 years, 5 months ago
On Fri, Sep 01, 2023 at 04:19:50PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 01, 2023 at 01:54:58PM +0100, Mark Brown wrote:

> > So do reviews which focus on very pedantic issues like this one...

> If you fine with a series as is, take it!

We are in the merge window right now so if I queue things I won't
actually apply them until the merge window is closed, meaning I need to
keep track of what's queued already when new versions come in or
whatever.

> It's really nothing to bikeshed about.

Well, quite.  What I do for these very minor issues if I do end up
commenting on them is mention them but explicitly say that the comment
is more for future reference and there's no need to resend.
Re: [PATCH v4 2/3] ASoC: wm8580: Remove trailing comma in the terminator entry
Posted by Charles Keepax 2 years, 5 months ago
On Fri, Sep 01, 2023 at 07:59:51AM +0100, Biju Das wrote:
> Remove trailing comma in the terminator entry for OF table.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles