md: fix potential hang for mddev_suspend()

[PATCH -next 0/2] md: fix potential hang for mddev_suspend()

Posted by Yu Kuai 2 years, 3 months ago

From: Yu Kuai <yukuai3@huawei.com>

Yu Kuai (2):
  md: factor out helpers to grab and put 'active_io'
  md: fix potential hang for mddev_suspend()

 drivers/md/md.c | 36 ++++++++++++++++++++++++++++++------
 1 file changed, 30 insertions(+), 6 deletions(-)

-- 
2.39.2

Re: [PATCH -next 0/2] md: fix potential hang for mddev_suspend()

Posted by Song Liu 2 years, 2 months ago

On Wed, Aug 30, 2023 at 2:33 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@huawei.com>
>
> Yu Kuai (2):
>   md: factor out helpers to grab and put 'active_io'
>   md: fix potential hang for mddev_suspend()

Applied to md-next. Thanks!

Song

>
>  drivers/md/md.c | 36 ++++++++++++++++++++++++++++++------
>  1 file changed, 30 insertions(+), 6 deletions(-)
>
> --
> 2.39.2
>

Re: [PATCH -next 0/2] md: fix potential hang for mddev_suspend()

Posted by Xiao Ni 2 years, 2 months ago

On Sat, Sep 23, 2023 at 5:33 AM Song Liu <song@kernel.org> wrote:
>
> On Wed, Aug 30, 2023 at 2:33 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
> >
> > From: Yu Kuai <yukuai3@huawei.com>
> >
> > Yu Kuai (2):
> >   md: factor out helpers to grab and put 'active_io'
> >   md: fix potential hang for mddev_suspend()
>
> Applied to md-next. Thanks!
>
> Song
>
> >
> >  drivers/md/md.c | 36 ++++++++++++++++++++++++++++++------
> >  1 file changed, 30 insertions(+), 6 deletions(-)
> >
> > --
> > 2.39.2
> >
>

Hi all

For the second patch, active_io_release does this job. So it doesn't
need to do this in md_array_exit again.

Best Regards
Xiao

Re: [PATCH -next 0/2] md: fix potential hang for mddev_suspend()

Posted by Yu Kuai 2 years, 2 months ago

Hi,

在 2023/09/25 15:58, Xiao Ni 写道:
> On Sat, Sep 23, 2023 at 5:33 AM Song Liu <song@kernel.org> wrote:
>>
>> On Wed, Aug 30, 2023 at 2:33 AM Yu Kuai <yukuai1@huaweicloud.com> wrote:
>>>
>>> From: Yu Kuai <yukuai3@huawei.com>
>>>
>>> Yu Kuai (2):
>>>    md: factor out helpers to grab and put 'active_io'
>>>    md: fix potential hang for mddev_suspend()
>>
>> Applied to md-next. Thanks!
>>
>> Song
>>
>>>
>>>   drivers/md/md.c | 36 ++++++++++++++++++++++++++++++------
>>>   1 file changed, 30 insertions(+), 6 deletions(-)
>>>
>>> --
>>> 2.39.2
>>>
>>
> 
> Hi all
> 
> For the second patch, active_io_release does this job. So it doesn't
> need to do this in md_array_exit again.

Yes, this is correct, I missed this while reviewing related code.

Song, can you revert this patchset for now? Sorry for the trouble.

Thanks,
Kuai

> 
> Best Regards
> Xiao
> 
> .
>