[PATCH v4 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear()

Yury Norov posted 8 patches 2 years, 5 months ago
There is a newer version of this series
[PATCH v4 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear()
Posted by Yury Norov 2 years, 5 months ago
_reg_op(REG_OP_RELEASE) duplicates bitmap_clear().

CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/bitmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 0fabcb0e4628..56595ce513f5 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1333,7 +1333,7 @@ EXPORT_SYMBOL(bitmap_find_free_region);
  */
 void bitmap_release_region(unsigned long *bitmap, unsigned int pos, int order)
 {
-	__reg_op(bitmap, pos, order, REG_OP_RELEASE);
+	bitmap_clear(bitmap, pos, pos + BIT(order));
 }
 EXPORT_SYMBOL(bitmap_release_region);
 
-- 
2.39.2
Re: [PATCH v4 5/8] bitmap: replace _reg_op(REG_OP_RELEASE) with bitmap_clear()
Posted by Andy Shevchenko 2 years, 5 months ago
On Mon, Aug 28, 2023 at 07:39:08PM -0700, Yury Norov wrote:
> _reg_op(REG_OP_RELEASE) duplicates bitmap_clear().

...

> -	__reg_op(bitmap, pos, order, REG_OP_RELEASE);
> +	bitmap_clear(bitmap, pos, pos + BIT(order));

Is it still buggy?

-- 
With Best Regards,
Andy Shevchenko