[PATCH v4 3/8] bitmap: fix opencoded bitmap_allocate_region()

Yury Norov posted 8 patches 2 years, 5 months ago
There is a newer version of this series
[PATCH v4 3/8] bitmap: fix opencoded bitmap_allocate_region()
Posted by Yury Norov 2 years, 5 months ago
bitmap_find_region() opencodes bitmap_allocate_region(). Fix it.

CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/bitmap.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 250715260d95..3c069944dd83 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1315,10 +1315,8 @@ int bitmap_find_free_region(unsigned long *bitmap, unsigned int bits, int order)
 	unsigned int pos, end;		/* scans bitmap by regions of size order */
 
 	for (pos = 0; (end = pos + BIT(order)) <= bits; pos = end) {
-		if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
-			continue;
-		__reg_op(bitmap, pos, order, REG_OP_ALLOC);
-		return pos;
+		if (!bitmap_allocate_region(bitmap, pos, order))
+			return pos;
 	}
 	return -ENOMEM;
 }
-- 
2.39.2
Re: [PATCH v4 3/8] bitmap: fix opencoded bitmap_allocate_region()
Posted by Andy Shevchenko 2 years, 5 months ago
On Mon, Aug 28, 2023 at 07:39:06PM -0700, Yury Norov wrote:
> bitmap_find_region() opencodes bitmap_allocate_region(). Fix it.

I don't think you "fix" anything here. You just refactor / replace the old code
with new one. I guess I made the same remark against v3.

-- 
With Best Regards,
Andy Shevchenko