[v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS

[PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS

Posted by Lukas Bulwahn 2 years, 3 months ago

Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
config FS_DEBUG. It is probably intended to select the existing config
XFS_DEBUG.

Fix the select in config XFS_ONLINE_SCRUB_STATS.

Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Darrick, please pick this quick 'typo' fix.

v2: removed a stupid last-minute insert on my Signed-off-by line.

 fs/xfs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index c9d653168ad0..ed0bc8cbc703 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
 	bool "XFS online metadata check usage data collection"
 	default y
 	depends on XFS_ONLINE_SCRUB
-	select FS_DEBUG
+	select XFS_DEBUG
 	help
 	  If you say Y here, the kernel will gather usage data about
 	  the online metadata check subsystem.  This includes the number
-- 
2.17.1

Re: [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS

Posted by Darrick J. Wong 2 years, 3 months ago

On Fri, Aug 25, 2023 at 02:05:13PM +0200, Lukas Bulwahn wrote:
> Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
> config FS_DEBUG. It is probably intended to select the existing config
> XFS_DEBUG.
> 
> Fix the select in config XFS_ONLINE_SCRUB_STATS.
> 
> Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Oops.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

> ---
> Darrick, please pick this quick 'typo' fix.

  ^^^^ isn't the maintainer anymore. ;)

--D

> v2: removed a stupid last-minute insert on my Signed-off-by line.
> 
>  fs/xfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index c9d653168ad0..ed0bc8cbc703 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
>  	bool "XFS online metadata check usage data collection"
>  	default y
>  	depends on XFS_ONLINE_SCRUB
> -	select FS_DEBUG
> +	select XFS_DEBUG
>  	help
>  	  If you say Y here, the kernel will gather usage data about
>  	  the online metadata check subsystem.  This includes the number
> -- 
> 2.17.1
>