[v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()

[PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()

Posted by Vern Hao 2 years, 5 months ago

From: Vern Hao <vernhao@tencent.com>

In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype().

Signed-off-by: Vern Hao <vernhao@tencent.com>
---
v1 -> v2
	- remove "Fixs:xxx" as David Hildenbrand suggestion.

 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 2b5d61eeb039..850811bb5699 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc)
 {
 	return !current_is_kswapd() &&
 			gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE &&
-			get_pageblock_migratetype(&folio->page) == MIGRATE_CMA;
+			folio_migratetype(folio) == MIGRATE_CMA;
 }
 #else
 static bool skip_cma(struct folio *folio, struct scan_control *sc)
-- 
2.41.0

Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype()

Posted by David Hildenbrand 2 years, 5 months ago

On 25.08.23 09:57, Vern Hao wrote:
> From: Vern Hao <vernhao@tencent.com>
> 
> In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype().
> 
> Signed-off-by: Vern Hao <vernhao@tencent.com>
> ---
> v1 -> v2
> 	- remove "Fixs:xxx" as David Hildenbrand suggestion.
> 
>   mm/vmscan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2b5d61eeb039..850811bb5699 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc)
>   {
>   	return !current_is_kswapd() &&
>   			gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE &&
> -			get_pageblock_migratetype(&folio->page) == MIGRATE_CMA;
> +			folio_migratetype(folio) == MIGRATE_CMA;

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb