[v1] MAINTAINERS: adjust file patterns in TQ SYSTEMS BOARD & DRIVER SUPPORT

[PATCH] MAINTAINERS: adjust file patterns in TQ SYSTEMS BOARD & DRIVER SUPPORT

Posted by Lukas Bulwahn 2 years, 5 months ago

Commit 77da3f22b3d5 ("MAINTAINERS: Add entry for TQ-Systems device trees
and drivers") adds some file patterns for files in arch/arm/boot/dts/, but
those patterns do not match any files in the repository. Hence,
./scripts/get_maintainer.pl --self-test=patterns complains about broken
references. The files of interest are actually in the directory
arch/arm/boot/dts/nxp/imx/.

Adjust the file patterns to match the intended files.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Lee, please pick this minor clean-up patch.

 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 52277ee9c1b8..f5d4058b7ff4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -21817,9 +21817,9 @@ TQ SYSTEMS BOARD & DRIVER SUPPORT
 L:	linux@ew.tq-group.com
 S:	Supported
 W:	https://www.tq-group.com/en/products/tq-embedded/
-F:	arch/arm/boot/dts/imx*mba*.dts*
-F:	arch/arm/boot/dts/imx*tqma*.dts*
-F:	arch/arm/boot/dts/mba*.dtsi
+F:	arch/arm/boot/dts/nxp/imx/imx*mba*.dts*
+F:	arch/arm/boot/dts/nxp/imx/imx*tqma*.dts*
+F:	arch/arm/boot/dts/nxp/imx/mba*.dtsi
 F:	arch/arm64/boot/dts/freescale/imx*mba*.dts*
 F:	arch/arm64/boot/dts/freescale/imx*tqma*.dts*
 F:	arch/arm64/boot/dts/freescale/mba*.dtsi
-- 
2.17.1

Re: [PATCH] MAINTAINERS: adjust file patterns in TQ SYSTEMS BOARD & DRIVER SUPPORT

Posted by Alexander Stein 2 years, 5 months ago

Hi Lukas,

Am Freitag, 25. August 2023, 07:58:21 CEST schrieb Lukas Bulwahn:
> Commit 77da3f22b3d5 ("MAINTAINERS: Add entry for TQ-Systems device trees
> and drivers") adds some file patterns for files in arch/arm/boot/dts/, but
> those patterns do not match any files in the repository. Hence,
> ./scripts/get_maintainer.pl --self-test=patterns complains about broken
> references. The files of interest are actually in the directory
> arch/arm/boot/dts/nxp/imx/.

Nice, I didn't know about --self-test=patterns. But you are right, the 
patterns do not match anymore since arch/arm dts restructuring.
I also suggest to add the Fixes tag:

Fixes: 77da3f22b3d54 ("MAINTAINERS: Add entry for TQ-Systems device trees and 
drivers")
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

> Adjust the file patterns to match the intended files.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Lee, please pick this minor clean-up patch.
> 
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 52277ee9c1b8..f5d4058b7ff4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -21817,9 +21817,9 @@ TQ SYSTEMS BOARD & DRIVER SUPPORT
>  L:	linux@ew.tq-group.com
>  S:	Supported
>  W:	https://www.tq-group.com/en/products/tq-embedded/
> -F:	arch/arm/boot/dts/imx*mba*.dts*
> -F:	arch/arm/boot/dts/imx*tqma*.dts*
> -F:	arch/arm/boot/dts/mba*.dtsi
> +F:	arch/arm/boot/dts/nxp/imx/imx*mba*.dts*
> +F:	arch/arm/boot/dts/nxp/imx/imx*tqma*.dts*
> +F:	arch/arm/boot/dts/nxp/imx/mba*.dtsi
>  F:	arch/arm64/boot/dts/freescale/imx*mba*.dts*
>  F:	arch/arm64/boot/dts/freescale/imx*tqma*.dts*
>  F:	arch/arm64/boot/dts/freescale/mba*.dtsi


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

Re: [PATCH] MAINTAINERS: adjust file patterns in TQ SYSTEMS BOARD & DRIVER SUPPORT

Posted by Alexander Stein 2 years, 3 months ago

Hi,

Am Freitag, 25. August 2023, 08:19:32 CET schrieb Alexander Stein:
> Hi Lukas,
> 
> Am Freitag, 25. August 2023, 07:58:21 CEST schrieb Lukas Bulwahn:
> > Commit 77da3f22b3d5 ("MAINTAINERS: Add entry for TQ-Systems device trees
> > and drivers") adds some file patterns for files in arch/arm/boot/dts/, but
> > those patterns do not match any files in the repository. Hence,
> > ./scripts/get_maintainer.pl --self-test=patterns complains about broken
> > references. The files of interest are actually in the directory
> > arch/arm/boot/dts/nxp/imx/.
> 
> Nice, I didn't know about --self-test=patterns. But you are right, the
> patterns do not match anymore since arch/arm dts restructuring.
> I also suggest to add the Fixes tag:
> 
> Fixes: 77da3f22b3d54 ("MAINTAINERS: Add entry for TQ-Systems device trees
> and drivers")
> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Any progress on this?
Thanks

Alexander

> > Adjust the file patterns to match the intended files.
> > 
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > Lee, please pick this minor clean-up patch.
> > 
> >  MAINTAINERS | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 52277ee9c1b8..f5d4058b7ff4 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21817,9 +21817,9 @@ TQ SYSTEMS BOARD & DRIVER SUPPORT
> > 
> >  L:	linux@ew.tq-group.com
> >  S:	Supported
> >  W:	https://www.tq-group.com/en/products/tq-embedded/
> > 
> > -F:	arch/arm/boot/dts/imx*mba*.dts*
> > -F:	arch/arm/boot/dts/imx*tqma*.dts*
> > -F:	arch/arm/boot/dts/mba*.dtsi
> > +F:	arch/arm/boot/dts/nxp/imx/imx*mba*.dts*
> > +F:	arch/arm/boot/dts/nxp/imx/imx*tqma*.dts*
> > +F:	arch/arm/boot/dts/nxp/imx/mba*.dtsi
> > 
> >  F:	arch/arm64/boot/dts/freescale/imx*mba*.dts*
> >  F:	arch/arm64/boot/dts/freescale/imx*tqma*.dts*
> >  F:	arch/arm64/boot/dts/freescale/mba*.dtsi


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/