SM6115 has a TX Macro, requiring an NPL clock, but not DCODEC.
Document it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
index 4156981fe02b..962701e9eb42 100644
--- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
@@ -13,6 +13,7 @@ properties:
compatible:
enum:
- qcom,sc7280-lpass-tx-macro
+ - qcom,sm6115-lpass-tx-macro
- qcom,sm8250-lpass-tx-macro
- qcom,sm8450-lpass-tx-macro
- qcom,sm8550-lpass-tx-macro
@@ -97,6 +98,23 @@ allOf:
- const: dcodec
- const: fsgen
+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,sm6115-lpass-tx-macro
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ maxItems: 4
+ clock-names:
+ items:
+ - const: mclk
+ - const: npl
+ - const: dcodec
+ - const: fsgen
+
- if:
properties:
compatible:
--
2.42.0
On 25/08/2023 19:23, Konrad Dybcio wrote: > SM6115 has a TX Macro, requiring an NPL clock, but not DCODEC. > Document it. > ... > > + - if: > + properties: > + compatible: > + enum: > + - qcom,sm6115-lpass-tx-macro > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 > + clock-names: > + items: > + - const: mclk > + - const: npl > + - const: dcodec > + - const: fsgen Are you sure there is no macro? This means there will be no LPASS_HW_MACRO_VOTE vote. Do you have downstream sources somewhere? Best regards, Krzysztof
On 26.08.2023 11:32, Krzysztof Kozlowski wrote: > On 25/08/2023 19:23, Konrad Dybcio wrote: >> SM6115 has a TX Macro, requiring an NPL clock, but not DCODEC. >> Document it. >> > > ... > >> >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,sm6115-lpass-tx-macro >> + then: >> + properties: >> + clocks: >> + minItems: 4 >> + maxItems: 4 >> + clock-names: >> + items: >> + - const: mclk >> + - const: npl >> + - const: dcodec >> + - const: fsgen > > Are you sure there is no macro? This means there will be no > LPASS_HW_MACRO_VOTE vote. Yes. Do you have downstream sources somewhere? Also yes, but they're not public.. Konrad
On 26/08/2023 11:37, Konrad Dybcio wrote: > On 26.08.2023 11:32, Krzysztof Kozlowski wrote: >> On 25/08/2023 19:23, Konrad Dybcio wrote: >>> SM6115 has a TX Macro, requiring an NPL clock, but not DCODEC. >>> Document it. >>> >> >> ... >> >>> >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,sm6115-lpass-tx-macro >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 4 >>> + maxItems: 4 >>> + clock-names: >>> + items: >>> + - const: mclk >>> + - const: npl >>> + - const: dcodec >>> + - const: fsgen >> >> Are you sure there is no macro? This means there will be no >> LPASS_HW_MACRO_VOTE vote. > Yes. > > Do you have downstream sources somewhere? > Also yes, but they're not public.. Indeed. Looks correct: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.