[PATCH net] sfc: Check firmware supports Ethernet PTP filter

alex.austin@amd.com posted 1 patch 2 years, 3 months ago
drivers/net/ethernet/sfc/ptp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[PATCH net] sfc: Check firmware supports Ethernet PTP filter
Posted by alex.austin@amd.com 2 years, 3 months ago
From: Alex Austin <alex.austin@amd.com>

Not all firmware variants support RSS filters. Do not fail all PTP
functionality when raw ethernet PTP filters fail to insert.

Fixes: e4616f64726b ("sfc: support PTP over Ethernet")
Signed-off-by: Alex Austin <alex.austin@amd.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
---
 drivers/net/ethernet/sfc/ptp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 0c40571133cb..00cf6de3bb2b 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -1485,7 +1485,9 @@ static int efx_ptp_insert_multicast_filters(struct efx_nic *efx)
 			goto fail;
 
 		rc = efx_ptp_insert_eth_multicast_filter(efx);
-		if (rc < 0)
+
+		/* Not all firmware variants support this filter */
+		if (rc < 0 && rc != -EPROTONOSUPPORT)
 			goto fail;
 	}
 
-- 
2.17.1
Re: [PATCH net] sfc: Check firmware supports Ethernet PTP filter
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 3 months ago
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 24 Aug 2023 17:46:57 +0100 you wrote:
> From: Alex Austin <alex.austin@amd.com>
> 
> Not all firmware variants support RSS filters. Do not fail all PTP
> functionality when raw ethernet PTP filters fail to insert.
> 
> Fixes: e4616f64726b ("sfc: support PTP over Ethernet")
> Signed-off-by: Alex Austin <alex.austin@amd.com>
> Acked-by: Edward Cree <ecree.xilinx@gmail.com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> 
> [...]

Here is the summary with links:
  - [net] sfc: Check firmware supports Ethernet PTP filter
    https://git.kernel.org/netdev/net/c/c4413a20fa6d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html