[PATCH] x86/hyperv: Remove duplicate include

Jiapeng Chong posted 1 patch 2 years, 3 months ago
arch/x86/hyperv/ivm.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] x86/hyperv: Remove duplicate include
Posted by Jiapeng Chong 2 years, 3 months ago
./arch/x86/hyperv/ivm.c: asm/sev.h is included more than once.
./arch/x86/hyperv/ivm.c: asm/coco.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6212
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 arch/x86/hyperv/ivm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 1448c6338971..55d43415a2fd 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -18,9 +18,7 @@
 #include <asm/mshyperv.h>
 #include <asm/hypervisor.h>
 #include <asm/mtrr.h>
-#include <asm/coco.h>
 #include <asm/io_apic.h>
-#include <asm/sev.h>
 #include <asm/realmode.h>
 #include <asm/e820/api.h>
 #include <asm/desc.h>
-- 
2.20.1.7.g153144c
Re: [PATCH] x86/hyperv: Remove duplicate include
Posted by Wei Liu 2 years, 3 months ago
On Thu, Aug 24, 2023 at 04:03:52PM +0800, Jiapeng Chong wrote:
> ./arch/x86/hyperv/ivm.c: asm/sev.h is included more than once.
> ./arch/x86/hyperv/ivm.c: asm/coco.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6212
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Applied to hyperv-next, thanks!
RE: [PATCH] x86/hyperv: Remove duplicate include
Posted by Dexuan Cui 2 years, 3 months ago
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Thursday, August 24, 2023 1:04 AM
> [...]
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> @@ -18,9 +18,7 @@
>  #include <asm/mshyperv.h>
>  #include <asm/hypervisor.h>
>  #include <asm/mtrr.h>
> -#include <asm/coco.h>
>  #include <asm/io_apic.h>
> -#include <asm/sev.h>
>  #include <asm/realmode.h>
>  #include <asm/e820/api.h>
>  #include <asm/desc.h>

I wish the header files were alphabetically ordered so that we
would have avoided the issue...

Reviewed-by: Dexuan Cui <decui@microsoft.com>