[PATCH] ceph: Remove duplicate include

Jiapeng Chong posted 1 patch 2 years, 3 months ago
fs/ceph/mds_client.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] ceph: Remove duplicate include
Posted by Jiapeng Chong 2 years, 3 months ago
./fs/ceph/mds_client.c: crypto.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/ceph/mds_client.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 7cfa0e3aedb4..9a3b617270c3 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -16,7 +16,6 @@
 #include "super.h"
 #include "crypto.h"
 #include "mds_client.h"
-#include "crypto.h"
 
 #include <linux/ceph/ceph_features.h>
 #include <linux/ceph/messenger.h>
-- 
2.20.1.7.g153144c
Re: [PATCH] ceph: Remove duplicate include
Posted by Xiubo Li 2 years, 3 months ago
On 8/24/23 15:54, Jiapeng Chong wrote:
> ./fs/ceph/mds_client.c: crypto.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   fs/ceph/mds_client.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 7cfa0e3aedb4..9a3b617270c3 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -16,7 +16,6 @@
>   #include "super.h"
>   #include "crypto.h"
>   #include "mds_client.h"
> -#include "crypto.h"
>   
>   #include <linux/ceph/ceph_features.h>
>   #include <linux/ceph/messenger.h>

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Re: [PATCH] ceph: Remove duplicate include
Posted by Ilya Dryomov 2 years, 3 months ago
On Thu, Aug 24, 2023 at 10:18 AM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 8/24/23 15:54, Jiapeng Chong wrote:
> > ./fs/ceph/mds_client.c: crypto.h is included more than once.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> >   fs/ceph/mds_client.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> > index 7cfa0e3aedb4..9a3b617270c3 100644
> > --- a/fs/ceph/mds_client.c
> > +++ b/fs/ceph/mds_client.c
> > @@ -16,7 +16,6 @@
> >   #include "super.h"
> >   #include "crypto.h"
> >   #include "mds_client.h"
> > -#include "crypto.h"
> >
> >   #include <linux/ceph/ceph_features.h>
> >   #include <linux/ceph/messenger.h>
>
> Reviewed-by: Xiubo Li <xiubli@redhat.com>

I folded the fix into "ceph: encode encrypted name in
ceph_mdsc_build_path and dentry release" commit.  Thanks for
the report!

                Ilya