1. Patchew
  2. linux
  3. [PATCH v2 0/7] arm64: qcom: sm8550: enable RNG
  4. View patch

[PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"

Neil Armstrong posted 7 patches 2 years, 3 months ago
There is a newer version of this series
[PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Neil Armstrong 2 years, 3 months ago 
This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
a more appropriate compatible should be instead as reported at [1].

[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/

Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 36b0ebd9a44b..bb42f4588b40 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,13 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    oneOf:
-      - enum:
-          - qcom,prng  # 8916 etc.
-          - qcom,prng-ee  # 8996 and later using EE
-      - items:
-          - const: qcom,sm8450-prng-ee
-          - const: qcom,prng-ee
+    enum:
+      - qcom,prng  # 8916 etc.
+      - qcom,prng-ee  # 8996 and later using EE
 
   reg:
     maxItems: 1
@@ -32,18 +28,8 @@ properties:
 required:
   - compatible
   - reg
-
-allOf:
-  - if:
-      not:
-        properties:
-          compatible:
-            contains:
-              const: qcom,sm8450-prng-ee
-    then:
-      required:
-        - clocks
-        - clock-names
+  - clocks
+  - clock-names
 
 additionalProperties: false
 

-- 
2.34.1
Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Herbert Xu 2 years, 3 months ago 
On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>  1 file changed, 5 insertions(+), 19 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Rob Herring 2 years, 3 months ago 
On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Is it just me or looks like an unrenderable character in these.

> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>  1 file changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> index 36b0ebd9a44b..bb42f4588b40 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
> @@ -11,13 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    oneOf:
> -      - enum:
> -          - qcom,prng  # 8916 etc.
> -          - qcom,prng-ee  # 8996 and later using EE
> -      - items:
> -          - const: qcom,sm8450-prng-ee
> -          - const: qcom,prng-ee
> +    enum:
> +      - qcom,prng  # 8916 etc.
> +      - qcom,prng-ee  # 8996 and later using EE
>  
>    reg:
>      maxItems: 1
> @@ -32,18 +28,8 @@ properties:
>  required:
>    - compatible
>    - reg
> -
> -allOf:
> -  - if:
> -      not:
> -        properties:
> -          compatible:
> -            contains:
> -              const: qcom,sm8450-prng-ee
> -    then:
> -      required:
> -        - clocks
> -        - clock-names
> +  - clocks
> +  - clock-names
>  
>  additionalProperties: false
>  
> 
> -- 
> 2.34.1
>
Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Om Prakash Singh 2 years, 3 months ago 

On 8/25/2023 2:59 AM, Rob Herring wrote:
> On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
>> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
>> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
>> a more appropriate compatible should be instead as reported at [1].
>>
>> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
>>
>> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> Is it just me or looks like an unrenderable character in these.
Yes there are spacial character before Om and Konrad that should have 
been removed.
> 
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>>   1 file changed, 5 insertions(+), 19 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 36b0ebd9a44b..bb42f4588b40 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -11,13 +11,9 @@ maintainers:
>>   
>>   properties:
>>     compatible:
>> -    oneOf:
>> -      - enum:
>> -          - qcom,prng  # 8916 etc.
>> -          - qcom,prng-ee  # 8996 and later using EE
>> -      - items:
>> -          - const: qcom,sm8450-prng-ee
>> -          - const: qcom,prng-ee
>> +    enum:
>> +      - qcom,prng  # 8916 etc.
>> +      - qcom,prng-ee  # 8996 and later using EE
>>   
>>     reg:
>>       maxItems: 1
>> @@ -32,18 +28,8 @@ properties:
>>   required:
>>     - compatible
>>     - reg
>> -
>> -allOf:
>> -  - if:
>> -      not:
>> -        properties:
>> -          compatible:
>> -            contains:
>> -              const: qcom,sm8450-prng-ee
>> -    then:
>> -      required:
>> -        - clocks
>> -        - clock-names
>> +  - clocks
>> +  - clock-names
>>   
>>   additionalProperties: false
>>   
>>
>> -- 
>> 2.34.1
>>
Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Neil Armstrong 2 years, 3 months ago 
Hi,

On 28/08/2023 08:25, Om Prakash Singh wrote:
> 
> 
> On 8/25/2023 2:59 AM, Rob Herring wrote:
>> On Thu, Aug 24, 2023 at 01:33:20PM +0200, Neil Armstrong wrote:
>>> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
>>> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
>>> a more appropriate compatible should be instead as reported at [1].
>>>
>>> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
>>>
>>> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>
>> Is it just me or looks like an unrenderable character in these.
> Yes there are spacial character before Om and Konrad that should have been removed.

Let me resend a v2 without this space and the review tags.

Neil

>>
>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> ---
>>>   .../devicetree/bindings/crypto/qcom,prng.yaml      | 24 +++++-----------------
>>>   1 file changed, 5 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> index 36b0ebd9a44b..bb42f4588b40 100644
>>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>>> @@ -11,13 +11,9 @@ maintainers:
>>>   properties:
>>>     compatible:
>>> -    oneOf:
>>> -      - enum:
>>> -          - qcom,prng  # 8916 etc.
>>> -          - qcom,prng-ee  # 8996 and later using EE
>>> -      - items:
>>> -          - const: qcom,sm8450-prng-ee
>>> -          - const: qcom,prng-ee
>>> +    enum:
>>> +      - qcom,prng  # 8916 etc.
>>> +      - qcom,prng-ee  # 8996 and later using EE
>>>     reg:
>>>       maxItems: 1
>>> @@ -32,18 +28,8 @@ properties:
>>>   required:
>>>     - compatible
>>>     - reg
>>> -
>>> -allOf:
>>> -  - if:
>>> -      not:
>>> -        properties:
>>> -          compatible:
>>> -            contains:
>>> -              const: qcom,sm8450-prng-ee
>>> -    then:
>>> -      required:
>>> -        - clocks
>>> -        - clock-names
>>> +  - clocks
>>> +  - clock-names
>>>   additionalProperties: false
>>>
>>> -- 
>>> 2.34.1
>>>
Re: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Posted by Konrad Dybcio 2 years, 3 months ago 
On 24.08.2023 13:33, Neil Armstrong wrote:
> This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
> since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
> a more appropriate compatible should be instead as reported at [1].
> 
> [1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
> 
> Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
> Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.