net: stmmac: Improve default addend/subsecond increment readability

[PATCH net-next 0/7] net: stmmac: Improve default addend/subsecond increment readability

Andrew Halaney posted 7 patches 2 years, 3 months ago

Download series mbox

drivers/net/ethernet/stmicro/stmmac/hwif.h         |  5 +++--
.../net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c  | 14 +++++++-------
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 22 ++++++++++++----------
3 files changed, 22 insertions(+), 19 deletions(-)

Expand all Fold all

[PATCH net-next 0/7] net: stmmac: Improve default addend/subsecond increment readability

Posted by Andrew Halaney 2 years, 3 months ago

This series aims to improve the readability of the calculations
for the default addend and subsecond increment values.

I recently had to understand what the hardware did by reading this code,
and it took me longer than I care to admit. These patches aim to make it
more self explanatory.

Suggestions to further improve this are very welcomed.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Andrew Halaney (7):
      net: stmmac: Use consistent variable name for subsecond increment
      net: stmmac: Use NSEC_PER_SEC for hwtstamp calculations
      net: stmmac: Precede entire addend calculation with its comment
      net: stmmac: Remove a pointless cast
      net: stmmac: Correct addend typo
      net: stmmac: Fix comment about default addend calculation
      net: stmmac: Make PTP reference clock references more clear

 drivers/net/ethernet/stmicro/stmmac/hwif.h         |  5 +++--
 .../net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c  | 14 +++++++-------
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  | 22 ++++++++++++----------
 3 files changed, 22 insertions(+), 19 deletions(-)
---
base-commit: 9f6708a668186dc5b38532fc1d1ff2f5311722d6
change-id: 20230824-stmmac-subsecond-inc-cleanup-305397c6ca8d

Best regards,
-- 
Andrew Halaney <ahalaney@redhat.com>