fixing ERROR: Macros with compex values must be enclosed within parentheses

[PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses

Posted by Anshul 2 years, 3 months ago

Signed-off-by: Anshul <anshulusr@gmail.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 08fcd2ffa727..8d3bcd18b652 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
 	.quirks = UVC_QUIRK_FORCE_Y8,
 };
 
-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
-	{.meta_format = m}
+#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
+#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})
 
 /*
  * The Logitech cameras listed below have their interface class set to
-- 
2.41.0

Re: [PATCH] fixing ERROR: Macros with compex values must be enclosed within parentheses

Posted by Laurent Pinchart 2 years, 3 months ago

Hi Anshul,

On Sat, Aug 19, 2023 at 07:01:13PM +0530, Anshul wrote:

The commit message must explain *why* the change is useful. In this
particular case, I don't think it is.

> Signed-off-by: Anshul <anshulusr@gmail.com>
> ---
>  drivers/media/usb/uvc/uvc_driver.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 08fcd2ffa727..8d3bcd18b652 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2417,9 +2417,8 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
>  	.quirks = UVC_QUIRK_FORCE_Y8,
>  };
>  
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> -	{.meta_format = m}
> +#define UVC_INFO_QUIRK(q) ((kernel_ulong_t)&(struct uvc_device_info){.quirks = q})
> +#define UVC_INFO_META(m) ((kernel_ulong_t)&(struct uvc_device_info) {.meta_format = m})
>  
>  /*
>   * The Logitech cameras listed below have their interface class set to

-- 
Regards,

Laurent Pinchart