scsi: pm8001: Remove unused declarations

[PATCH -next] scsi: pm8001: Remove unused declarations

Posted by Yue Haibing 2 years, 4 months ago

Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
removed these implementations but not the declarations.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/scsi/pm8001/pm8001_sas.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
index 953572fc0d9e..2fadd353f1c1 100644
--- a/drivers/scsi/pm8001/pm8001_sas.h
+++ b/drivers/scsi/pm8001/pm8001_sas.h
@@ -702,8 +702,6 @@ int pm8001_mpi_fw_flash_update_resp(struct pm8001_hba_info *pm8001_ha,
 							void *piomb);
 int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha, void *piomb);
 int pm8001_mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb);
-struct sas_task *pm8001_alloc_task(void);
-void pm8001_free_task(struct sas_task *task);
 void pm8001_tag_free(struct pm8001_hba_info *pm8001_ha, u32 tag);
 struct pm8001_device *pm8001_find_dev(struct pm8001_hba_info *pm8001_ha,
 					u32 device_id);
-- 
2.34.1

Re: [PATCH -next] scsi: pm8001: Remove unused declarations

Posted by Martin K. Petersen 2 years, 3 months ago

On Fri, 18 Aug 2023 20:47:00 +0800, Yue Haibing wrote:

> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
> 
> 

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: pm8001: Remove unused declarations
      https://git.kernel.org/mkp/scsi/c/04aff456af18

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH -next] scsi: pm8001: Remove unused declarations

Posted by Martin K. Petersen 2 years, 3 months ago

Yue,

> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH -next] scsi: pm8001: Remove unused declarations

Posted by Jinpu Wang 2 years, 3 months ago

On Fri, Aug 18, 2023 at 2:47 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
>  drivers/scsi/pm8001/pm8001_sas.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi/pm8001/pm8001_sas.h
> index 953572fc0d9e..2fadd353f1c1 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.h
> +++ b/drivers/scsi/pm8001/pm8001_sas.h
> @@ -702,8 +702,6 @@ int pm8001_mpi_fw_flash_update_resp(struct pm8001_hba_info *pm8001_ha,
>                                                         void *piomb);
>  int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha, void *piomb);
>  int pm8001_mpi_task_abort_resp(struct pm8001_hba_info *pm8001_ha, void *piomb);
> -struct sas_task *pm8001_alloc_task(void);
> -void pm8001_free_task(struct sas_task *task);
>  void pm8001_tag_free(struct pm8001_hba_info *pm8001_ha, u32 tag);
>  struct pm8001_device *pm8001_find_dev(struct pm8001_hba_info *pm8001_ha,
>                                         u32 device_id);
> --
> 2.34.1
>

Re: [PATCH -next] scsi: pm8001: Remove unused declarations

Posted by Bart Van Assche 2 years, 3 months ago

On 8/18/23 05:47, Yue Haibing wrote:
> Commit 4fcf812ca392 ("[SCSI] libsas: export sas_alloc_task()")
> removed these implementations but not the declarations.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>