[PATCH] ubifs: fix missing error code err

Ferry Meng posted 1 patch 2 years, 4 months ago
[PATCH] ubifs: fix missing error code err
Posted by Ferry Meng 2 years, 4 months ago
Fix smatch warning:

fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
'err'

Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>

diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index dc52ac0f4a34..ab837b73d4b9 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
 				ubifs_err(c, "bad data node (block %u, inode %lu)",
 					  blk, inode->i_ino);
 				ubifs_dump_node(c, dn, dn_size);
+				err = -EUCLEAN;
 				goto out_free;
 			}
 
-- 
2.19.1.6.gb485710b
Re: [PATCH] ubifs: fix missing error code err
Posted by Zhihao Cheng 2 years, 4 months ago
在 2023/8/18 17:18, Ferry Meng 写道:
> Fix smatch warning:
> 
> fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
> 'err'
> 
> Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index dc52ac0f4a34..ab837b73d4b9 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
>   				ubifs_err(c, "bad data node (block %u, inode %lu)",
>   					  blk, inode->i_ino);
>   				ubifs_dump_node(c, dn, dn_size);
> +				err = -EUCLEAN;
>   				goto out_free;
>   			}
>   
>