[PATCH] fuse: make fuse_valid_size static

Jiapeng Chong posted 1 patch 2 years, 4 months ago
fs/fuse/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] fuse: make fuse_valid_size static
Posted by Jiapeng Chong 2 years, 4 months ago
The fuse_valid_size are not used outside the file dir.c, so the
modification is defined as static.

fs/fuse/dir.c:353:6: warning: no previous prototype for ‘fuse_valid_size’.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/fuse/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index fb505c1fba02..0cf7c3dbd578 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -350,7 +350,7 @@ int fuse_valid_type(int m)
 		S_ISBLK(m) || S_ISFIFO(m) || S_ISSOCK(m);
 }
 
-bool fuse_valid_size(u64 size)
+static bool fuse_valid_size(u64 size)
 {
 	return size <= LLONG_MAX;
 }
-- 
2.20.1.7.g153144c

Re: [PATCH] fuse: make fuse_valid_size static
Posted by Miklos Szeredi 2 years, 3 months ago
On Thu, 17 Aug 2023 at 04:25, Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The fuse_valid_size are not used outside the file dir.c, so the
> modification is defined as static.

Thanks, folded.

Miklos