[PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()

Uwe Kleine-König posted 1 patch 2 years, 4 months ago
drivers/fsi/fsi-master-i2cr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
Posted by Uwe Kleine-König 2 years, 4 months ago
struct i2c_driver::probe_new is about to go away. Switch the driver to
use the probe callback with the same prototype.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,

this driver appeared in next just today. I intend to drop .probe_new
from struct i2c_driver after v6.6-rc1, so it would be great if this
patch would go in together with the commit adding this driver.

Thanks
Uwe

 drivers/fsi/fsi-master-i2cr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
index 61659c27a973..40f1f4d231e5 100644
--- a/drivers/fsi/fsi-master-i2cr.c
+++ b/drivers/fsi/fsi-master-i2cr.c
@@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
 MODULE_DEVICE_TABLE(of, i2cr_ids);
 
 static struct i2c_driver i2cr_driver = {
-	.probe_new = i2cr_probe,
+	.probe = i2cr_probe,
 	.remove = i2cr_remove,
 	.driver = {
 		.name = "fsi-master-i2cr",

base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
-- 
2.40.1

Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
Posted by Joel Stanley 2 years, 3 months ago
On Wed, 16 Aug 2023 at 17:20, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.

Reviewed-by: Joel Stanley <joel@jms.id.au>

Greg, can you please take this for 6.6?

>
> Thanks
> Uwe
>
>  drivers/fsi/fsi-master-i2cr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
>  MODULE_DEVICE_TABLE(of, i2cr_ids);
>
>  static struct i2c_driver i2cr_driver = {
> -       .probe_new = i2cr_probe,
> +       .probe = i2cr_probe,
>         .remove = i2cr_remove,
>         .driver = {
>                 .name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b
> --
> 2.40.1
>
Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
Posted by Greg Kroah-Hartman 2 years, 3 months ago
On Mon, Aug 21, 2023 at 04:57:52AM +0000, Joel Stanley wrote:
> On Wed, 16 Aug 2023 at 17:20, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > struct i2c_driver::probe_new is about to go away. Switch the driver to
> > use the probe callback with the same prototype.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > this driver appeared in next just today. I intend to drop .probe_new
> > from struct i2c_driver after v6.6-rc1, so it would be great if this
> > patch would go in together with the commit adding this driver.
> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 
> Greg, can you please take this for 6.6?

Yes, will do, thanks.

greg k-h
Re: [PATCH] fsi: i2cr: Switch to use struct i2c_driver's .probe()
Posted by Eddie James 2 years, 4 months ago
On 8/16/23 12:19, Uwe Kleine-König wrote:
> struct i2c_driver::probe_new is about to go away. Switch the driver to
> use the probe callback with the same prototype.


Thanks!


Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> this driver appeared in next just today. I intend to drop .probe_new
> from struct i2c_driver after v6.6-rc1, so it would be great if this
> patch would go in together with the commit adding this driver.
>
> Thanks
> Uwe
>
>   drivers/fsi/fsi-master-i2cr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c
> index 61659c27a973..40f1f4d231e5 100644
> --- a/drivers/fsi/fsi-master-i2cr.c
> +++ b/drivers/fsi/fsi-master-i2cr.c
> @@ -301,7 +301,7 @@ static const struct of_device_id i2cr_ids[] = {
>   MODULE_DEVICE_TABLE(of, i2cr_ids);
>   
>   static struct i2c_driver i2cr_driver = {
> -	.probe_new = i2cr_probe,
> +	.probe = i2cr_probe,
>   	.remove = i2cr_remove,
>   	.driver = {
>   		.name = "fsi-master-i2cr",
>
> base-commit: 53e89e3e4490d6630a68e61a3cb478e7a7f2ce8b