[PATCH 2/2] media: ivsc: Add ACPI dependency

Sakari Ailus posted 2 patches 2 years, 4 months ago
[PATCH 2/2] media: ivsc: Add ACPI dependency
Posted by Sakari Ailus 2 years, 4 months ago
The IVSC driver only works in ACPI systems so make it depend on ACPI.

Compiling it elsewhere has little if any value.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
 drivers/media/pci/intel/ivsc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
index ec4ade92f583..413053175df7 100644
--- a/drivers/media/pci/intel/ivsc/Kconfig
+++ b/drivers/media/pci/intel/ivsc/Kconfig
@@ -3,7 +3,7 @@
 
 config INTEL_VSC
 	tristate "Intel Visual Sensing Controller"
-	depends on INTEL_MEI
+	depends on INTEL_MEI && ACPI
 	help
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
-- 
2.39.2
Re: [PATCH 2/2] media: ivsc: Add ACPI dependency
Posted by Randy Dunlap 2 years, 4 months ago

On 8/16/23 06:35, Sakari Ailus wrote:
> The IVSC driver only works in ACPI systems so make it depend on ACPI.
> 
> Compiling it elsewhere has little if any value.
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
>  drivers/media/pci/intel/ivsc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
> index ec4ade92f583..413053175df7 100644
> --- a/drivers/media/pci/intel/ivsc/Kconfig
> +++ b/drivers/media/pci/intel/ivsc/Kconfig
> @@ -3,7 +3,7 @@
>  
>  config INTEL_VSC
>  	tristate "Intel Visual Sensing Controller"
> -	depends on INTEL_MEI
> +	depends on INTEL_MEI && ACPI
>  	help
>  	  This adds support for Intel Visual Sensing Controller (IVSC).
>  

-- 
~Randy