arm64: dts: qcom: sc7280: drop unsupported qcom,adsp-bypass-mode

[PATCH] arm64: dts: qcom: sc7280: drop unsupported qcom,adsp-bypass-mode

Posted by Krzysztof Kozlowski 2 years, 4 months ago

LPASS LPI pin controller node binding does not allow
qcom,adsp-bypass-mode property:

  sc7280-herobrine-crd.dtb: pinctrl@33c0000: 'qcom,adsp-bypass-mode' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'

Fixes: 32d4541abe0f ("arm64: dts: qcom: sc7280: add lpass lpi pin controller node")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index dbcd139f60f1..d8b12666e592 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2498,7 +2498,6 @@ lpass_tlmm: pinctrl@33c0000 {
 			compatible = "qcom,sc7280-lpass-lpi-pinctrl";
 			reg = <0 0x033c0000 0x0 0x20000>,
 				<0 0x03550000 0x0 0x10000>;
-			qcom,adsp-bypass-mode;
 			gpio-controller;
 			#gpio-cells = <2>;
 			gpio-ranges = <&lpass_tlmm 0 0 15>;
-- 
2.34.1

Re: [PATCH] arm64: dts: qcom: sc7280: drop unsupported qcom,adsp-bypass-mode

Posted by Konrad Dybcio 2 years, 4 months ago

On 16.08.2023 08:00, Krzysztof Kozlowski wrote:
> LPASS LPI pin controller node binding does not allow
> qcom,adsp-bypass-mode property:
> 
>   sc7280-herobrine-crd.dtb: pinctrl@33c0000: 'qcom,adsp-bypass-mode' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
> 
> Fixes: 32d4541abe0f ("arm64: dts: qcom: sc7280: add lpass lpi pin controller node")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Looks like it was never picked up

https://lore.kernel.org/linux-arm-msm/20230714-topic-lpass_lpi_cleanup-v1-3-dc18b5bd14f7@linaro.org/

Konrad

Re: [PATCH] arm64: dts: qcom: sc7280: drop unsupported qcom,adsp-bypass-mode

Posted by Doug Anderson 2 years, 4 months ago

Hi,

On Wed, Aug 16, 2023 at 4:41 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 16.08.2023 08:00, Krzysztof Kozlowski wrote:
> > LPASS LPI pin controller node binding does not allow
> > qcom,adsp-bypass-mode property:
> >
> >   sc7280-herobrine-crd.dtb: pinctrl@33c0000: 'qcom,adsp-bypass-mode' does not match any of the regexes: '-state$', 'pinctrl-[0-9]+'
> >
> > Fixes: 32d4541abe0f ("arm64: dts: qcom: sc7280: add lpass lpi pin controller node")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> Looks like it was never picked up
>
> https://lore.kernel.org/linux-arm-msm/20230714-topic-lpass_lpi_cleanup-v1-3-dc18b5bd14f7@linaro.org/
>
> Konrad

Yeah, it seems like picking up Konrad's is better. If nothing else,
the "Fixes" tag in ${SUBJECT} is wrong. This property was actually
valid/required on older kernels IIRC.

-Doug