[PATCH v3 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set()

Yury Norov posted 8 patches 2 years, 4 months ago
There is a newer version of this series
[PATCH v3 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set()
Posted by Yury Norov 2 years, 4 months ago
_reg_op(REG_OP_ALLOC) duplicates bitmap_set(). Fix it.

Signed-off-by: Yury Norov <yury.norov@gmail.com>
---
 lib/bitmap.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 4c9f119240cc..b7ea47b9f09d 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1354,9 +1354,12 @@ EXPORT_SYMBOL(bitmap_release_region);
  */
 int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order)
 {
+	unsigned int len = BIT(order);
+
 	if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
 		return -EBUSY;
-	return __reg_op(bitmap, pos, order, REG_OP_ALLOC);
+	bitmap_set(bitmap, pos, len);
+	return 0;
 }
 EXPORT_SYMBOL(bitmap_allocate_region);
 
-- 
2.39.2
Re: [PATCH v3 4/8] bitmap: replace _reg_op(REG_OP_ALLOC) with bitmap_set()
Posted by Andy Shevchenko 2 years, 4 months ago
On Tue, Aug 15, 2023 at 04:36:24PM -0700, Yury Norov wrote:
> _reg_op(REG_OP_ALLOC) duplicates bitmap_set(). Fix it.

This is not a fix.

-- 
With Best Regards,
Andy Shevchenko