drivers/usb/core/hub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
This patch fixes following checkpatch.pl issue:
ERROR: code indent should use tabs where possible
Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
---
drivers/usb/core/hub.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 97a0f8faea6e..1e56efe9214b 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1777,7 +1777,7 @@ static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
if (!usb_endpoint_is_int_in(&desc->endpoint[0].desc))
return false;
- return true;
+ return true;
}
static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
@@ -5840,14 +5840,14 @@ static void hub_event(struct work_struct *work)
static const struct usb_device_id hub_id_table[] = {
{ .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT
- | USB_DEVICE_ID_MATCH_INT_CLASS,
+ | USB_DEVICE_ID_MATCH_PRODUCT
+ | USB_DEVICE_ID_MATCH_INT_CLASS,
.idVendor = USB_VENDOR_SMSC,
.idProduct = USB_PRODUCT_USB5534B,
.bInterfaceClass = USB_CLASS_HUB,
.driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
{ .match_flags = USB_DEVICE_ID_MATCH_VENDOR
- | USB_DEVICE_ID_MATCH_PRODUCT,
+ | USB_DEVICE_ID_MATCH_PRODUCT,
.idVendor = USB_VENDOR_CYPRESS,
.idProduct = USB_PRODUCT_CY7C65632,
.driver_info = HUB_QUIRK_DISABLE_AUTOSUSPEND},
--
2.25.1
On Wed, Aug 16, 2023 at 02:14:39AM +0530, Atul Kumar Pant wrote: > This patch fixes following checkpatch.pl issue: > ERROR: code indent should use tabs where possible > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > --- > drivers/usb/core/hub.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) You didn't mention "hub" in the subject? Again, please start out by doing work in drivers/staging/ to learn how to write good patches, before venturing out into other areas of the kernel. Fixing up whitespace issues in random kernel parts is not always encouraged. thanks, greg k-h
On Tue, Aug 15, 2023 at 11:08:02PM +0200, Greg KH wrote: > On Wed, Aug 16, 2023 at 02:14:39AM +0530, Atul Kumar Pant wrote: > > This patch fixes following checkpatch.pl issue: > > ERROR: code indent should use tabs where possible > > > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com> > > --- > > drivers/usb/core/hub.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > You didn't mention "hub" in the subject? > > Again, please start out by doing work in drivers/staging/ to learn how > to write good patches, before venturing out into other areas of the > kernel. Fixing up whitespace issues in random kernel parts is not > always encouraged. Sure Greg, I'll check /drivers/staging/ and will avoid doing whitespace changes in random kernel parts. > > thanks, > > greg k-h
© 2016 - 2025 Red Hat, Inc.