[PATCH] kselftest/arm64: fix a memleak in zt_regs_run()

Ding Xiang posted 1 patch 2 years, 4 months ago
tools/testing/selftests/arm64/signal/testcases/zt_regs.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] kselftest/arm64: fix a memleak in zt_regs_run()
Posted by Ding Xiang 2 years, 4 months ago
If memcmp() does not return 0, "zeros" need to be freed to prevent memleak

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
 tools/testing/selftests/arm64/signal/testcases/zt_regs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c
index e1eb4d5c027a..2e384d731618 100644
--- a/tools/testing/selftests/arm64/signal/testcases/zt_regs.c
+++ b/tools/testing/selftests/arm64/signal/testcases/zt_regs.c
@@ -65,6 +65,7 @@ int zt_regs_run(struct tdescr *td, siginfo_t *si, ucontext_t *uc)
 	if (memcmp(zeros, (char *)zt + ZT_SIG_REGS_OFFSET,
 		   ZT_SIG_REGS_SIZE(zt->nregs)) != 0) {
 		fprintf(stderr, "ZT data invalid\n");
+		free(zeros);
 		return 1;
 	}
 
-- 
2.38.1
Re: [PATCH] kselftest/arm64: fix a memleak in zt_regs_run()
Posted by Will Deacon 2 years, 4 months ago
On Tue, 15 Aug 2023 15:49:15 +0800, Ding Xiang wrote:
> If memcmp() does not return 0, "zeros" need to be freed to prevent memleak
> 
> 

Applied to arm64 (for-next/selftests), thanks!

[1/1] kselftest/arm64: fix a memleak in zt_regs_run()
      https://git.kernel.org/arm64/c/46862da15e37

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev