[v3] scsi: ufs: convert probe to use dev_err_probe()

[PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe()

Posted by Brian Masney 2 years ago

The following two log messages are shown on bootup due to an
-EPROBE_DEFER when booting on a Qualcomm sa8775p development board:

    ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
        failed err -517
    ufshcd-qcom 1d84000.ufs: Initialization failed

This patch series converts the relevant two probe functions over to use
dev_err_probe() so that these messages are not shown on bootup.

Changes since v2
https://lore.kernel.org/lkml/20230809191054.2197963-1-bmasney@redhat.com/
- Add error code to message in second patch

Changes since v1
https://lore.kernel.org/lkml/20230808142650.1713432-1-bmasney@redhat.com/
- Dropped code cleanup from first patch

Brian Masney (2):
  scsi: ufs: core: convert to dev_err_probe() in hba_init
  scsi: ufs: host: convert to dev_err_probe() in pltfrm_init

 drivers/ufs/core/ufshcd.c        | 5 +++--
 drivers/ufs/host/ufshcd-pltfrm.c | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.41.0

Re: [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe()

Posted by Martin K. Petersen 2 years ago

On Mon, 14 Aug 2023 14:43:50 -0400, Brian Masney wrote:

> The following two log messages are shown on bootup due to an
> -EPROBE_DEFER when booting on a Qualcomm sa8775p development board:
> 
>     ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
>         failed err -517
>     ufshcd-qcom 1d84000.ufs: Initialization failed
> 
> [...]

Applied to 6.6/scsi-queue, thanks!

[1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init
      https://git.kernel.org/mkp/scsi/c/137523237172
[2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init
      https://git.kernel.org/mkp/scsi/c/517f8eb3fa64

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe()

Posted by Martin K. Petersen 2 years ago

Brian,

> The following two log messages are shown on bootup due to an
> -EPROBE_DEFER when booting on a Qualcomm sa8775p development board:
>
>     ufshcd-qcom 1d84000.ufs: ufshcd_variant_hba_init: variant qcom init
>         failed err -517
>     ufshcd-qcom 1d84000.ufs: Initialization failed
>
> This patch series converts the relevant two probe functions over to use
> dev_err_probe() so that these messages are not shown on bootup.

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering