[PATCH] scsi: isci: init Return result of sas_register_ha()

Artem Chernyshev posted 1 patch 2 years, 4 months ago
drivers/scsi/isci/init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH] scsi: isci: init Return result of sas_register_ha()
Posted by Artem Chernyshev 2 years, 4 months ago
To properly manage possible failure of sas_register_ha() in
isci_register_sas_ha() return it's result instead of zero

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>
---
 drivers/scsi/isci/init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index ac1e04b86d8f..4f4800edf4f0 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -264,9 +264,7 @@ static int isci_register_sas_ha(struct isci_host *isci_host)
 
 	sas_ha->strict_wide_ports = 1;
 
-	sas_register_ha(sas_ha);
-
-	return 0;
+	return sas_register_ha(sas_ha);
 }
 
 static void isci_unregister(struct isci_host *isci_host)
-- 
2.37.3
Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
Posted by Martin K. Petersen 2 years, 3 months ago
On Sun, 13 Aug 2023 23:23:36 +0300, Artem Chernyshev wrote:

> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> 

Applied to 6.6/scsi-queue, thanks!

[1/1] scsi: isci: init Return result of sas_register_ha()
      https://git.kernel.org/mkp/scsi/c/9a23ed57abbb

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
Posted by Martin K. Petersen 2 years, 3 months ago
Artem,

> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero

Applied to 6.6/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: isci: init Return result of sas_register_ha()
Posted by Artur Paszkiewicz 2 years, 4 months ago
On 13.08.2023 22:23, Artem Chernyshev wrote:
> To properly manage possible failure of sas_register_ha() in
> isci_register_sas_ha() return it's result instead of zero
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru>

Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>