ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

[PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

Posted by David Heidelberg 2 years, 4 months ago

Fixes warning generated by `make qcom-msm8960-cdp.dtb`:
arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index c10797f3793c..c20f16845a97 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -47,7 +47,7 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x0>;
 	};
-- 
2.40.1

Re: [PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

Posted by Konrad Dybcio 2 years, 3 months ago

On 12.08.2023 20:32, David Heidelberg wrote:
> Fixes warning generated by `make qcom-msm8960-cdp.dtb`:
> arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
But does it really?

i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory
or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?

Konrad
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index c10797f3793c..c20f16845a97 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -47,7 +47,7 @@ L2: l2-cache {
>  		};
>  	};
>  
> -	memory {
> +	memory@0 {
>  		device_type = "memory";
>  		reg = <0x0 0x0>;
>  	};

Re: [PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0

Posted by David Heidelberg 1 year, 5 months ago

Can we get this in then?

Thanks
David

On 25/08/2023 04:57, Konrad Dybcio wrote:
> On 12.08.2023 20:32, David Heidelberg wrote:
>> Fixes warning generated by `make qcom-msm8960-cdp.dtb`:
>> arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
> But does it really?
>
> i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory
> or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?
>
> Konrad
>>   arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> index c10797f3793c..c20f16845a97 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> @@ -47,7 +47,7 @@ L2: l2-cache {
>>   		};
>>   	};
>>   
>> -	memory {
>> +	memory@0 {
>>   		device_type = "memory";
>>   		reg = <0x0 0x0>;
>>   	};

-- 
David Heidelberg