[PATCH 10/17] zorro: include zorro.h in names.c

Arnd Bergmann posted 17 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH 10/17] zorro: include zorro.h in names.c
Posted by Arnd Bergmann 2 years, 1 month ago
From: Arnd Bergmann <arnd@arndb.de>

The zorro_name_device() function is defined in drivers/zorror/names.c, but
the declaration is not visible there:

drivers/zorro/names.c:58:13: error: no previous prototype for 'zorro_name_device' [-Werror=missing-prototypes]
   58 | void __init zorro_name_device(struct zorro_dev *dev)

Include the header to avoid the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/zorro/names.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/zorro/names.c b/drivers/zorro/names.c
index fa3c83dbe8431..077114ccc8407 100644
--- a/drivers/zorro/names.c
+++ b/drivers/zorro/names.c
@@ -15,6 +15,7 @@
 #include <linux/types.h>
 #include <linux/zorro.h>
 
+#include "zorro.h"
 
 struct zorro_prod_info {
 	__u16 prod;
-- 
2.39.2
Re: [PATCH 10/17] zorro: include zorro.h in names.c
Posted by Geert Uytterhoeven 2 years ago
On Thu, Aug 10, 2023 at 4:22 PM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The zorro_name_device() function is defined in drivers/zorror/names.c, but
> the declaration is not visible there:
>
> drivers/zorro/names.c:58:13: error: no previous prototype for 'zorro_name_device' [-Werror=missing-prototypes]
>    58 | void __init zorro_name_device(struct zorro_dev *dev)
>
> Include the header to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
i.e. will queue in the m68k for-v6.6 branch, with the "zorror" typo fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds