[v2] staging: vt6655: Change camel case variables to snake case

[PATCH v2] staging: vt6655: Change camel case variables to snake case

Posted by Mingzai Sun 2 years, 1 month ago

Remove the unneeded "by" prefix.

Signed-off-by: Mingzai Sun <szp2017@gmail.com>
---
Changes in v2:
  - Change "by_contnt_offset" to "contnt_offset".
---
 drivers/staging/vt6655/srom.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index 812964ab68c5..1b89d401a7eb 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -49,7 +49,7 @@
  * Parameters:
  *  In:
  *      iobase          - I/O base address
- *      by_contnt_offset  - address of EEPROM
+ *      contnt_offset  - address of EEPROM
  *  Out:
  *      none
  *
@@ -57,7 +57,7 @@
  *
  */
 unsigned char SROMbyReadEmbedded(void __iomem *iobase,
-				 unsigned char by_contnt_offset)
+				 unsigned char contnt_offset)
 {
 	unsigned short wDelay, wNoACK;
 	unsigned char byWait;
@@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
 	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
 	for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
 		iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
-		iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
+		iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
 
 		/* issue read command */
 		iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
-- 
2.34.1

Re: [PATCH v2] staging: vt6655: Change camel case variables to snake case

Posted by Greg KH 2 years, 1 month ago

On Thu, Aug 10, 2023 at 10:08:34PM +0800, Mingzai Sun wrote:
> Remove the unneeded "by" prefix.
> 
> Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> ---
> Changes in v2:
>   - Change "by_contnt_offset" to "contnt_offset".
> ---
>  drivers/staging/vt6655/srom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 812964ab68c5..1b89d401a7eb 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
>   * Parameters:
>   *  In:
>   *      iobase          - I/O base address
> - *      by_contnt_offset  - address of EEPROM
> + *      contnt_offset  - address of EEPROM
>   *  Out:
>   *      none
>   *
> @@ -57,7 +57,7 @@
>   *
>   */
>  unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> -				 unsigned char by_contnt_offset)
> +				 unsigned char contnt_offset)
>  {
>  	unsigned short wDelay, wNoACK;
>  	unsigned char byWait;
> @@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
>  	iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
>  	for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
>  		iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
> -		iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
> +		iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
>  
>  		/* issue read command */
>  		iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
> -- 
> 2.34.1
> 
> 

This patch does not apply to my tree at all :(