thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

[PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

Posted by Andrei Coardos 2 years, 6 months ago

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.

Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
 drivers/thermal/k3_bandgap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
index 1c3e590157ec..f985f36f2123 100644
--- a/drivers/thermal/k3_bandgap.c
+++ b/drivers/thermal/k3_bandgap.c
@@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
 		devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
 	}
 
-	platform_set_drvdata(pdev, bgp);
 
 	return 0;
 
-- 
2.34.1

Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

Posted by Daniel Lezcano 2 years, 5 months ago

On 10/08/2023 13:23, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
> 
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---

Applied, thanks

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

Posted by Alexandru Ardelean 2 years, 6 months ago

On Thu, Aug 10, 2023 at 2:23 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
>  drivers/thermal/k3_bandgap.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
> index 1c3e590157ec..f985f36f2123 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
>                 devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
>         }
>
> -       platform_set_drvdata(pdev, bgp);
>
>         return 0;
>
> --
> 2.34.1
>