[PATCH 1/2] dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region

Vignesh Raghavendra posted 2 patches 2 years, 6 months ago
[PATCH 1/2] dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region
Posted by Vignesh Raghavendra 2 years, 6 months ago
RINGACC module on K3 SoCs have CFG register region which is usually
configured by a Device Management firmware. But certain entities such as
bootloader (like U-Boot) may have to access them directly. Describe this
region in the binding documentation for completeness of module
description.

Keep the binding compatible with existing DTS files by requiring first
four regions to be present at least.

Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
---
 Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
index 22cf9002fee7..a08959c6e072 100644
--- a/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml
@@ -34,18 +34,22 @@ properties:
       - const: ti,am654-navss-ringacc
 
   reg:
+    minItems: 4
     items:
       - description: real time registers regions
       - description: fifos registers regions
       - description: proxy gcfg registers regions
       - description: proxy target registers regions
+      - description: configuration registers region
 
   reg-names:
+    minItems: 4
     items:
       - const: rt
       - const: fifos
       - const: proxy_gcfg
       - const: proxy_target
+      - const: cfg
 
   msi-parent: true
 
@@ -80,8 +84,9 @@ examples:
             reg = <0x0 0x3c000000 0x0 0x400000>,
                   <0x0 0x38000000 0x0 0x400000>,
                   <0x0 0x31120000 0x0 0x100>,
-                  <0x0 0x33000000 0x0 0x40000>;
-            reg-names = "rt", "fifos", "proxy_gcfg", "proxy_target";
+                  <0x0 0x33000000 0x0 0x40000>,
+                  <0x0 0x31080000 0x0 0x40000>;
+                  reg-names = "rt", "fifos", "proxy_gcfg", "proxy_target", "cfg";
             ti,num-rings = <818>;
             ti,sci-rm-range-gp-rings = <0x2>; /* GP ring range */
             ti,sci = <&dmsc>;
-- 
2.41.0
Re: [PATCH 1/2] dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region
Posted by Conor Dooley 2 years, 6 months ago
On Wed, Aug 09, 2023 at 11:29:31PM +0530, Vignesh Raghavendra wrote:
> RINGACC module on K3 SoCs have CFG register region which is usually
> configured by a Device Management firmware. But certain entities such as
> bootloader (like U-Boot) may have to access them directly. Describe this
> region in the binding documentation for completeness of module
> description.
> 
> Keep the binding compatible with existing DTS files by requiring first
> four regions to be present at least.
> 
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.