Ringacc on TI K3 SoCs have configuration registers region which is
usually hidden from Linux and configured via Device Manager Firmware
APIs. But certain early SWs like bootloader which run before Device
Manager is fully up would need to directly configure these registers and
thus require to be in DT description.

This add bindings for the cfg region and also adds them to DT files.
Backward compatibility is maintained to existing DT by only mandating
existing regions to be present and this new region as optional.

Nishanth: I am hoping its possible for you to take bindings and DT
via k3-dts-next once reviewed.

Vignesh Raghavendra (2):
  dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region
  arm64: dts: ti: k3: Add cfg reg region to ringacc node

 Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml | 9 +++++++--
 arch/arm64/boot/dts/ti/k3-am65-main.dtsi                 | 5 +++--
 arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi                  | 6 ++++--
 arch/arm64/boot/dts/ti/k3-j7200-main.dtsi                | 5 +++--
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi          | 6 ++++--
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 5 +++--
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi          | 5 +++--
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 5 +++--
 arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi         | 5 +++--
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi               | 5 +++--
 arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi         | 5 +++--
 11 files changed, 39 insertions(+), 22 deletions(-)

-- 
2.41.0

Hi Vignesh,

On 09/08/2023 20:59, Vignesh Raghavendra wrote:
> Ringacc on TI K3 SoCs have configuration registers region which is
> usually hidden from Linux and configured via Device Manager Firmware
> APIs. But certain early SWs like bootloader which run before Device
> Manager is fully up would need to directly configure these registers and
> thus require to be in DT description.
> 
> This add bindings for the cfg region and also adds them to DT files.
> Backward compatibility is maintained to existing DT by only mandating
> existing regions to be present and this new region as optional.
> 
> Nishanth: I am hoping its possible for you to take bindings and DT
> via k3-dts-next once reviewed.

I have similar concern/question as for the DMA side, let me copy that
here as well:
These regions were 'hidden' from Linux or other open coded access for a
reason.
If I recall the main reason is security and the need to make sure that
the allocation of the channels not been violated.

IMho the boot loader should be no exception and it should be using the
DM firmware to configure the DMAs.

Or has the security concern been dropped and SW can do whatever it wants?

> 
> Vignesh Raghavendra (2):
>    dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region
>    arm64: dts: ti: k3: Add cfg reg region to ringacc node
> 
>   Documentation/devicetree/bindings/soc/ti/k3-ringacc.yaml | 9 +++++++--
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi                 | 5 +++--
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi                  | 6 ++++--
>   arch/arm64/boot/dts/ti/k3-j7200-main.dtsi                | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi          | 6 ++++--
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi                | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi          | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi               | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi         | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi               | 5 +++--
>   arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi         | 5 +++--
>   11 files changed, 39 insertions(+), 22 deletions(-)
> 

-- 
Péter

Hi Vignesh Raghavendra,

On Wed, 9 Aug 2023 23:29:30 +0530, Vignesh Raghavendra wrote:
> Ringacc on TI K3 SoCs have configuration registers region which is
> usually hidden from Linux and configured via Device Manager Firmware
> APIs. But certain early SWs like bootloader which run before Device
> Manager is fully up would need to directly configure these registers and
> thus require to be in DT description.
> 
> This add bindings for the cfg region and also adds them to DT files.
> Backward compatibility is maintained to existing DT by only mandating
> existing regions to be present and this new region as optional.
> 
> [...]

I have assumed here with Conor's ack that this will flow through TI SoC tree.
Do let me know if that is not the case.

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] dt-bindings: soc: ti: k3-ringacc: Describe cfg reg region
      commit: 4f1e869915b7a8c48a0501ad0b102002013a7b7a
[2/2] arm64: dts: ti: k3: Add cfg reg region to ringacc node
      commit: 702110c2be999c1ad354ca6e14e8583ebcea2462

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 

Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D