[PATCH 1/7] arm64: dts: qcom: apq8016-sbc: Fix ov5640 regulator supply names

Bryan O'Donoghue posted 7 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH 1/7] arm64: dts: qcom: apq8016-sbc: Fix ov5640 regulator supply names
Posted by Bryan O'Donoghue 2 years, 1 month ago
The ov5640 driver expects DOVDD, AVDD and DVDD as regulator supply names.

The ov5640 has depended on these names since the driver was committed
upstream in 2017. Similarly apq8016-sbc.dtsi has had completely different
regulator names since its own initial commit in 2020.

Perhaps the regulators were left on in previous 410c bootloaders. In any
case today on 6.5 we won't switch on the ov5640 without correctly naming
the regulators.

Fixes: 39e0ce6cd1bf ("arm64: dts: qcom: apq8016-sbc: Add CCI/Sensor nodes")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index f6eeb25988465..75b4e5ff7c95c 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -282,9 +282,9 @@ camera_rear@3b {
 		clock-names = "xclk";
 		clock-frequency = <23880000>;
 
-		vdddo-supply = <&camera_vdddo_1v8>;
-		vdda-supply = <&camera_vdda_2v8>;
-		vddd-supply = <&camera_vddd_1v5>;
+		DOVDD-supply = <&camera_vdddo_1v8>;
+		AVDD-supply = <&camera_vdda_2v8>;
+		DVDD-supply = <&camera_vddd_1v5>;
 
 		/* No camera mezzanine by default */
 		status = "disabled";
-- 
2.39.2
Re: [PATCH 1/7] arm64: dts: qcom: apq8016-sbc: Fix ov5640 regulator supply names
Posted by Konrad Dybcio 2 years, 1 month ago
On 9.08.2023 14:04, Bryan O'Donoghue wrote:
> The ov5640 driver expects DOVDD, AVDD and DVDD as regulator supply names.
> 
> The ov5640 has depended on these names since the driver was committed
> upstream in 2017. Similarly apq8016-sbc.dtsi has had completely different
> regulator names since its own initial commit in 2020.
> 
> Perhaps the regulators were left on in previous 410c bootloaders. In any
> case today on 6.5 we won't switch on the ov5640 without correctly naming
> the regulators.
> 
> Fixes: 39e0ce6cd1bf ("arm64: dts: qcom: apq8016-sbc: Add CCI/Sensor nodes")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad