[v1] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

[PATCH] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

Posted by Jinghao Jia 2 years, 1 month ago

The BUILD_VDSO macro was incorrectly spelled as BULID_VDSO in
asm/linkage.h. This causes the !defined(BULID_VDSO) directive to always
evaluate to true.

Correct the spelling to BUILD_VDSO.

Fixes: bea75b33895f ("x86/Kconfig: Introduce function padding")
Signed-off-by: Jinghao Jia <jinghao@linux.ibm.com>
---
 arch/x86/include/asm/linkage.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
index 0953aa32a324..97a3de7892d3 100644
--- a/arch/x86/include/asm/linkage.h
+++ b/arch/x86/include/asm/linkage.h
@@ -21,7 +21,7 @@
 #define FUNCTION_PADDING
 #endif
 
-#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BULID_VDSO)
+#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
 # define __FUNC_ALIGN		__ALIGN; FUNCTION_PADDING
 #else
 # define __FUNC_ALIGN		__ALIGN
-- 
2.41.0

Re: [PATCH] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

Posted by Randy Dunlap 2 years, 1 month ago


On 8/8/23 11:23, Jinghao Jia wrote:
> The BUILD_VDSO macro was incorrectly spelled as BULID_VDSO in
> asm/linkage.h. This causes the !defined(BULID_VDSO) directive to always
> evaluate to true.
> 
> Correct the spelling to BUILD_VDSO.
> 
> Fixes: bea75b33895f ("x86/Kconfig: Introduce function padding")
> Signed-off-by: Jinghao Jia <jinghao@linux.ibm.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  arch/x86/include/asm/linkage.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
> index 0953aa32a324..97a3de7892d3 100644
> --- a/arch/x86/include/asm/linkage.h
> +++ b/arch/x86/include/asm/linkage.h
> @@ -21,7 +21,7 @@
>  #define FUNCTION_PADDING
>  #endif
>  
> -#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BULID_VDSO)
> +#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
>  # define __FUNC_ALIGN		__ALIGN; FUNCTION_PADDING
>  #else
>  # define __FUNC_ALIGN		__ALIGN

-- 
~Randy

[tip: x86/urgent] x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

Posted by tip-bot2 for Jinghao Jia 2 years, 1 month ago

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     7324f74d39531262b8e362f228b46512e6bee632
Gitweb:        https://git.kernel.org/tip/7324f74d39531262b8e362f228b46512e6bee632
Author:        Jinghao Jia <jinghao@linux.ibm.com>
AuthorDate:    Tue, 08 Aug 2023 14:23:53 -04:00
Committer:     Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Tue, 08 Aug 2023 23:13:17 +02:00

x86/linkage: Fix typo of BUILD_VDSO in asm/linkage.h

The BUILD_VDSO macro was incorrectly spelled as BULID_VDSO in
asm/linkage.h. This causes the !defined(BULID_VDSO) directive to always
evaluate to true.

Correct the spelling to BUILD_VDSO.

Fixes: bea75b33895f ("x86/Kconfig: Introduce function padding")
Signed-off-by: Jinghao Jia <jinghao@linux.ibm.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Cc: <stable@kernel.org>
Link: https://lore.kernel.org/r/20230808182353.76218-1-jinghao@linux.ibm.com
---
 arch/x86/include/asm/linkage.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h
index 0953aa3..97a3de7 100644
--- a/arch/x86/include/asm/linkage.h
+++ b/arch/x86/include/asm/linkage.h
@@ -21,7 +21,7 @@
 #define FUNCTION_PADDING
 #endif
 
-#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BULID_VDSO)
+#if (CONFIG_FUNCTION_ALIGNMENT > 8) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO)
 # define __FUNC_ALIGN		__ALIGN; FUNCTION_PADDING
 #else
 # define __FUNC_ALIGN		__ALIGN