[PATCH -next v2] regulator: Make clkin_name and xin_name static

GUO Zihua posted 1 patch 2 years, 1 month ago
drivers/regulator/raa215300.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH -next v2] regulator: Make clkin_name and xin_name static
Posted by GUO Zihua 2 years, 1 month ago
clkin_name and xin_name is not referred elsewhere, so make them static.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
---

v2:
  Re-formatted patch and tested on the most current master.

---
 drivers/regulator/raa215300.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/raa215300.c b/drivers/regulator/raa215300.c
index 24a1c89f5dbc..d21c6c207226 100644
--- a/drivers/regulator/raa215300.c
+++ b/drivers/regulator/raa215300.c
@@ -38,8 +38,8 @@
 #define RAA215300_REG_BLOCK_EN_RTC_EN	BIT(6)
 #define RAA215300_RTC_DEFAULT_ADDR	0x6f
 
-const char *clkin_name = "clkin";
-const char *xin_name = "xin";
+static const char *clkin_name = "clkin";
+static const char *xin_name = "xin";
 static struct clk *clk;
 
 static const struct regmap_config raa215300_regmap_config = {
-- 
2.17.1
Re: [PATCH -next v2] regulator: Make clkin_name and xin_name static
Posted by Mark Brown 2 years, 1 month ago
On Mon, Aug 07, 2023 at 09:50:27AM +0800, GUO Zihua wrote:
> clkin_name and xin_name is not referred elsewhere, so make them static.
> 
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> ---
> 
> v2:
>   Re-formatted patch and tested on the most current master.

This still doesn't apply against my current tree, please check and
resend.  It should apply against the for-6.6 branch.
Re: [PATCH -next v2] regulator: Make clkin_name and xin_name static
Posted by Guozihua (Scott) 2 years, 1 month ago
On 2023/8/7 21:36, Mark Brown wrote:
> On Mon, Aug 07, 2023 at 09:50:27AM +0800, GUO Zihua wrote:
>> clkin_name and xin_name is not referred elsewhere, so make them static.
>>
>> Signed-off-by: GUO Zihua <guozihua@huawei.com>
>> ---
>>
>> v2:
>>   Re-formatted patch and tested on the most current master.
> 
> This still doesn't apply against my current tree, please check and
> resend.  It should apply against the for-6.6 branch.

Hi Mark,

This patch does not seems to be needed on next anymore. Please ignore it
and thanks for your time!

-- 
Best
GUO Zihua