drivers/staging/vt6655/srom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Change camel case to snake case.
Issue found by checkpatch.
Signed-off-by: Mingzai Sun <szp2017@gmail.com>
---
drivers/staging/vt6655/srom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index ee5ca4db74dc..812964ab68c5 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -49,7 +49,7 @@
* Parameters:
* In:
* iobase - I/O base address
- * byContntOffset - address of EEPROM
+ * by_contnt_offset - address of EEPROM
* Out:
* none
*
@@ -57,7 +57,7 @@
*
*/
unsigned char SROMbyReadEmbedded(void __iomem *iobase,
- unsigned char byContntOffset)
+ unsigned char by_contnt_offset)
{
unsigned short wDelay, wNoACK;
unsigned char byWait;
@@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
- iowrite8(byContntOffset, iobase + MAC_REG_I2MTGAD);
+ iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
/* issue read command */
iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
--
2.34.1On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote: > Change camel case to snake case. > Issue found by checkpatch. > > Signed-off-by: Mingzai Sun <szp2017@gmail.com> > --- > drivers/staging/vt6655/srom.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c > index ee5ca4db74dc..812964ab68c5 100644 > --- a/drivers/staging/vt6655/srom.c > +++ b/drivers/staging/vt6655/srom.c > @@ -49,7 +49,7 @@ > * Parameters: > * In: > * iobase - I/O base address > - * byContntOffset - address of EEPROM > + * by_contnt_offset - address of EEPROM Why did you keep the unneeded "by" prefix? thanks, greg k-h
Greg KH <gregkh@linuxfoundation.org> 于2023年8月9日周三 20:21写道： > > On Sat, Aug 05, 2023 at 11:57:39AM +0800, Mingzai Sun wrote: > > Change camel case to snake case. > > Issue found by checkpatch. > > > > Signed-off-by: Mingzai Sun <szp2017@gmail.com> > > --- > > drivers/staging/vt6655/srom.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c > > index ee5ca4db74dc..812964ab68c5 100644 > > --- a/drivers/staging/vt6655/srom.c > > +++ b/drivers/staging/vt6655/srom.c > > @@ -49,7 +49,7 @@ > > * Parameters: > > * In: > > * iobase - I/O base address > > - * byContntOffset - address of EEPROM > > + * by_contnt_offset - address of EEPROM > > Why did you keep the unneeded "by" prefix? > > thanks, > > greg k-h OK, I will remove the "by" prefix in the second patch.
Remove the unneeded "by" prefix.
Signed-off-by: Mingzai Sun <szp2017@gmail.com>
---
Changes in v2:
- Change "by_contnt_offset" to "contnt_offset".
---
drivers/staging/vt6655/srom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
index 812964ab68c5..1b89d401a7eb 100644
--- a/drivers/staging/vt6655/srom.c
+++ b/drivers/staging/vt6655/srom.c
@@ -49,7 +49,7 @@
* Parameters:
* In:
* iobase - I/O base address
- * by_contnt_offset - address of EEPROM
+ * contnt_offset - address of EEPROM
* Out:
* none
*
@@ -57,7 +57,7 @@
*
*/
unsigned char SROMbyReadEmbedded(void __iomem *iobase,
- unsigned char by_contnt_offset)
+ unsigned char contnt_offset)
{
unsigned short wDelay, wNoACK;
unsigned char byWait;
@@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
- iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
+ iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
/* issue read command */
iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
--
2.34.1On Thu, Aug 10, 2023 at 10:08:34PM +0800, Mingzai Sun wrote:
> Remove the unneeded "by" prefix.
>
> Signed-off-by: Mingzai Sun <szp2017@gmail.com>
> ---
> Changes in v2:
> - Change "by_contnt_offset" to "contnt_offset".
> ---
> drivers/staging/vt6655/srom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/srom.c b/drivers/staging/vt6655/srom.c
> index 812964ab68c5..1b89d401a7eb 100644
> --- a/drivers/staging/vt6655/srom.c
> +++ b/drivers/staging/vt6655/srom.c
> @@ -49,7 +49,7 @@
> * Parameters:
> * In:
> * iobase - I/O base address
> - * by_contnt_offset - address of EEPROM
> + * contnt_offset - address of EEPROM
> * Out:
> * none
> *
> @@ -57,7 +57,7 @@
> *
> */
> unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> - unsigned char by_contnt_offset)
> + unsigned char contnt_offset)
> {
> unsigned short wDelay, wNoACK;
> unsigned char byWait;
> @@ -70,7 +70,7 @@ unsigned char SROMbyReadEmbedded(void __iomem *iobase,
> iowrite8(byOrg & (~I2MCFG_NORETRY), iobase + MAC_REG_I2MCFG);
> for (wNoACK = 0; wNoACK < W_MAX_I2CRETRY; wNoACK++) {
> iowrite8(EEP_I2C_DEV_ID, iobase + MAC_REG_I2MTGID);
> - iowrite8(by_contnt_offset, iobase + MAC_REG_I2MTGAD);
> + iowrite8(contnt_offset, iobase + MAC_REG_I2MTGAD);
>
> /* issue read command */
> iowrite8(I2MCSR_EEMR, iobase + MAC_REG_I2MCSR);
> --
> 2.34.1
>
>
This patch does not apply to my tree at all :(
© 2016 - 2026 Red Hat, Inc.