[PATCH v3 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false

Kemeng Shi posted 8 patches 2 years, 1 month ago
There is a newer version of this series
[PATCH v3 8/8] mm/compaction: only set skip flag if cc->no_set_skip_hint is false
Posted by Kemeng Shi 2 years, 1 month ago
Keep the same logic as update_pageblock_skip, only set skip if
no_set_skip_hint is false which is more reasonable.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
 mm/compaction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 81be1d0b9622..ea61922a1619 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1443,7 +1443,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn)
 	isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
 
 	/* Skip this pageblock in the future as it's full or nearly full */
-	if (start_pfn == end_pfn)
+	if (start_pfn == end_pfn && !cc->no_set_skip_hint)
 		set_pageblock_skip(page);
 }
 
-- 
2.30.0