[PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes

Arnd Bergmann posted 7 patches 2 years, 6 months ago
arch/x86/boot/compressed/error.c          |  2 +-
arch/x86/boot/compressed/error.h          |  2 +-
arch/x86/include/asm/div64.h              |  6 ++++++
arch/x86/include/asm/microcode_amd.h      |  3 +--
arch/x86/include/asm/paravirt.h           |  7 +++++++
arch/x86/include/asm/processor.h          |  2 ++
arch/x86/include/asm/qspinlock.h          |  7 +------
arch/x86/include/asm/qspinlock_paravirt.h |  2 ++
arch/x86/kernel/alternative.c             |  1 +
arch/x86/kernel/apic/ipi.c                |  2 ++
arch/x86/kernel/paravirt.c                |  3 ++-
arch/x86/purgatory/purgatory.c            |  1 +
kernel/locking/qspinlock_paravirt.h       | 20 ++++++++++----------
13 files changed, 37 insertions(+), 21 deletions(-)
[PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes
Posted by Arnd Bergmann 2 years, 6 months ago
From: Arnd Bergmann <arnd@arndb.de>

This is almost the same as before, and should let us turn
on -Wmissing-prototypes by default. I'm still unsure whether
we need to do this per architecture as some other ones still
produce a lot of warnings, or we just enabled it for everyone
and let arch maintainers deal with it now that the major
ones (x86, arm64, arm, powerpc, riscv, s390) are clean.

Changes compared to v2:
 - add amd_check_microcode() patch to the series. I had
   sent that separately as this was a regression in 6.5-rc

 - rework comment for __div64_32

 - split paravirt patch into two patches and rewrite
   the native_pv_lock_init() one as requested by Boris

      Arnd

Arnd Bergmann (7):
  x86: Fix amd_check_microcode() declaration
  x86: apic: hide unused safe_smp_processor_id on UP
  x86: avoid unneeded __div64_32 function definition
  x86: purgatory: include header for warn() declaration
  x86: alternative: add __alt_reloc_selftest prototype
  x86: paravirt: shut up unused native_pv_lock_init() function warning
  x86: qspinlock-paravirt: fix mising-prototype warning

 arch/x86/boot/compressed/error.c          |  2 +-
 arch/x86/boot/compressed/error.h          |  2 +-
 arch/x86/include/asm/div64.h              |  6 ++++++
 arch/x86/include/asm/microcode_amd.h      |  3 +--
 arch/x86/include/asm/paravirt.h           |  7 +++++++
 arch/x86/include/asm/processor.h          |  2 ++
 arch/x86/include/asm/qspinlock.h          |  7 +------
 arch/x86/include/asm/qspinlock_paravirt.h |  2 ++
 arch/x86/kernel/alternative.c             |  1 +
 arch/x86/kernel/apic/ipi.c                |  2 ++
 arch/x86/kernel/paravirt.c                |  3 ++-
 arch/x86/purgatory/purgatory.c            |  1 +
 kernel/locking/qspinlock_paravirt.h       | 20 ++++++++++----------
 13 files changed, 37 insertions(+), 21 deletions(-)

-- 
2.39.2
Re: [PATCH v3 0/7] x86: remaining -Wmissing-prototype warning fixes
Posted by Borislav Petkov 2 years, 6 months ago
On Thu, Aug 03, 2023 at 10:26:12AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This is almost the same as before, and should let us turn
> on -Wmissing-prototypes by default. I'm still unsure whether
> we need to do this per architecture as some other ones still
> produce a lot of warnings, or we just enabled it for everyone
> and let arch maintainers deal with it now that the major

Yeah, might wanna ask them first.

I definitely want this finally enabled so that we can finally put this
one to rest.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette